Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

freifunk-policyrouting: do not add to ucitrack multiple times #1774

Closed

Conversation

SvenRoederer
Copy link
Contributor

Do not update ucitrack when the last list already has the correct option set. This prevents from adding the same items on every upgrade.

Signed-off-by: Sven Roederer freifunk@it-solutions.geroedel.de

Do not update ucitrack when the last list already has the correct option set. This prevents from adding the same items on every upgrade.

Signed-off-by: Sven Roederer <freifunk@it-solutions.geroedel.de>
@feckert
Copy link
Member

feckert commented May 25, 2018

@SvenRoederer
I think you should remove the entry first and then add this entry again.
If the entry is present (old one) then replace this with a new one.
And additional in the end return with "exit 0".
This will delete the uci default file and will not get executed on next boot.

This is best practice.
See for example:
https://github.com/openwrt/luci/blob/44bf3f0c1640040561306caff39f34ac916b4357/applications/luci-app-olsr/root/etc/uci-defaults/40_luci-olsr

@SvenRoederer
Copy link
Contributor Author

This should be reopened under the upcoming freifunk-repo (https://github.com/freifunk/openwrt-packages)

@feckert
Copy link
Member

feckert commented Aug 2, 2019

Please reopen this pullrequest in the new freifunk feed because package is already moved.
So I will close this there.

@feckert feckert closed this Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants