luci-base: view: make checkboxes and radio buttons styleable #663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an empty, normally invisible label after checkboxes and radio buttons
with cbi-input-{checkbox,radio} classes to allow CSS styling them as
suggested on http://www.paulund.co.uk/style-checkboxes-with-css
Signed-off-by: Nils Schneider <nils@nilsschneider.net>
Signed-off-by: Matthias Schiffer <mschiffer@universe-factory.net>
|
Pull into my test branch to verify nothing breaks. |
|
No issues in my build and run test, looks fine, and no comments for many months. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an empty, normally invisible label after checkboxes and radio buttons
with cbi-input-{checkbox,radio} classes to allow CSS styling them as
suggested on http://www.paulund.co.uk/style-checkboxes-with-css
This is another patch we've been carrying in Gluon for some time, allow us to get the nice styled checkboxes in our config mode theme ( https://kbu.freifunk.net/wiki/images/thumb/a/ad/Gluon-config-welcome.png/800px-Gluon-config-welcome.png ).
I've extended our patch to add such an label for all instances of cbi-input-{checkbox,radio} (I hope I didn't miss any...) I also moved two "id" attributes from enclosing s to an element to allow referencing the from the added labels, but I didn't understand why those s had ids in the first place, so I hope my changes don't break anything.