luci-mod-admin-full: show realtime wlan graph only if iw command is installed #859
Conversation
|
This appears to me to be wrong. Realtime graphs in trunk use luci-bwc which uses libiwinfo not iw binary. |
danielfdickinson
added
R: invalid
more information needed
|
@feckert Is this a 15.05 bug fix of some kind? |
|
@cshoredaniel i am working on 15.05 and i have a target without wlan and the wlan packages are not installed. But the realtime graph always show the wlan tab. So i test for iw if it is installed, and if not then i am on a target without wlan supported. The source in trunk looks the same and there is no test too. So i think it is useful for trunk as well. |
|
@feckert How about checking for /etc/config/wireless - it should exist if wlan is at all present and should not exist if it is not. e.g. if fs.access("/etc/config/wireless") then ... |
|
@cshoredaniel I will to PR update on monday 👍 |
danielfdickinson
removed
the
more information needed
|
@feckert no rush, and if you could run test it too, that would help. |
…nstalled Signed-off-by: Florian Eckert <Eckert.Florian@googlemail.com>
feckert
force-pushed
the
realtime_wlan
branch
from
c25d184
to
3c7d766
Compare
|
@cshoredaniel i am not shure if you get an update if i make a "git push --force" so i want to infrom you that I have update the PR |
|
@feckert thank you - I did miss this notification too...will get to it soon |
|
@jow- Should this go in for-15.05 as well? |
Signed-off-by: Florian Eckert Eckert.Florian@googlemail.com