Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

does mt76x2_eeprom contain invalid values? #48

Open
psyborg55 opened this issue Sep 5, 2016 · 1 comment
Open

does mt76x2_eeprom contain invalid values? #48

psyborg55 opened this issue Sep 5, 2016 · 1 comment

Comments

@psyborg55
Copy link

psyborg55 commented Sep 5, 2016

looking at the code i see there is quite some defines missing, and some are possibly wrong!

for example:

MT_EE_LNA_GAIN =          0x044,
MT_EE_RSSI_OFFSET_2G_0 =        0x046,
MT_EE_RSSI_OFFSET_2G_1 =        0x048,
MT_EE_RSSI_OFFSET_5G_0 =        0x04a,
MT_EE_RSSI_OFFSET_5G_1 =        0x04c,

this would mean the data for chain 0 are not read since in my factory eeprom this field is 00. it is also wrong name RSSI_OFFSET for what the driver assumes it works with but it should be renamed to LNA_GAIN

according to MT7612E EEPROM content guideline

it should be:

MT_EE_LNA_GAIN_2G =           0x044,
MT_EE_LNA_GAIN_5G_GROUP1 =      0x045,
MT_EE_RSSI_OFFSET_2G_0 =        0x046,
MT_EE_RSSI_OFFSET_2G_1 =        0x047,
MT_EE_LNA_GAIN_5G_GROUP2 =      0x049,
MT_EE_RSSI_OFFSET_5G_0 =        0x04a,
MT_EE_RSSI_OFFSET_5G_1 =        0x04b,
MT_EE_LNA_GAIN_5G_GROUP3 =      0x04d,
@xavier83
Copy link

bump? where is this 'content guideline'?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants