miniupnpd: add force_forwarding option support #16011
Conversation
This option replace the 'ext_ip_reserved_ignore', and replace the patch with new one as addr_is_reserved() behavior should not be changed, so drop the ext_ip_reserved_ignore use a force_forwarding option to make the port forwarding force to work when the router is behind NAT Signed-off-by: Chen Minqiang <ptpt52@gmail.com>
|
need some tested |
|
#15258 |
There was a problem hiding this comment.
Even though I appreciate your work, I am not in favor to merge this because what happened here: #15258
We can not carry patches, which are refused to be part of upstream and are causing several issues, and then they are reported upstream, which they need to solve and refuse it as they are right about it.
If you want to have this merged, send this upstream, cooperate with them to be sure that it is accepted, and once it is merged, it can be backported here or you can wait until it's part of a new release.
For now, I am closing this to prevent the situation, which happened in the past. You should really remove the patch which you created. Because this is not an acceptable state. Users are confused about what to do with the error message, which is cryptic and does not say many details what to do.
|
@Neustradamus I test this pr in openwrt package and find not work， i can report bug here，thks a lot |
|
@openips try to enable stun |
|
specify the wan interface: |
|
@ptpt52 我还是习惯您之前的301补丁的工作方式 非常省心 能否修改一下 |
|
try this one: x-wrt/packages@62b923a |
|
好的 我编译一下试试看 结果稍后反馈 |
|
|
| @@ -2,6 +2,7 @@ config upnpd config | |||
| option enabled 0 | |||
| option enable_natpmp 1 | |||
| option enable_upnp 1 | |||
| option force_forwarding 1 | |||
There was a problem hiding this comment.
Please don't make this option default. Previously when you made ext_ip_reserved_ignore default, it resulted in cryptic syslog messages for miniupnpd users outside of China.
|
Please do a PR for master only first, then we will backport once reviewed ;) |
|
@ptpt52: Important: Please do new PRs for 18.06.x/19.07.x/21.02.x/master branches.
Thanks a lot in advance. PS: @neheb: Too late to have same miniupnp version in 18.06.x/19.07.x/21.07.x/master? |
|
it not work at 23.03 fw4，focre_forwarding or ext_ip_reserved_ignore Illegal parameter when i add in /var/etc/miniupnp.conf。 |
these two config options never supported by upstream miniupnpd |
Does it mean that I need to merge patch and compile myself？ |
|
@ptpt52 |
This option replace the 'ext_ip_reserved_ignore', and replace the
patch with new one
as addr_is_reserved() behavior should not be changed, so drop the
ext_ip_reserved_ignore
use a force_forwarding option to make the port forwarding force to
work when the router is behind NAT
Maintainer: me / @<github-user> (find it by checking history of the package Makefile)
Compile tested: (put here arch, model, OpenWrt version)
Run tested: (put here arch, model, OpenWrt version, tests done)
Description: