Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21.02] python-pynacl: missing ed25519 patch #18177

Closed
mcbridematt opened this issue Mar 29, 2022 · 1 comment
Closed

[21.02] python-pynacl: missing ed25519 patch #18177

mcbridematt opened this issue Mar 29, 2022 · 1 comment

Comments

@mcbridematt
Copy link
Contributor

After 4f7fcd9 ("libsodium: include ed25519_core in minimal build") was backported into the 21.02 branch, python3-pynacl now fails to compile:

cc1: note: someone does not honour COPTS correctly, passed 4 times
build/temp.linux-mips-3.9/_sodium.c:588:10: error: 'crypto_core_ed25519_bytes' redeclared as different kind of symbol
 size_t (*crypto_core_ed25519_bytes)() = NULL;
          ^~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /home/matt/openwrt/staging_dir/target-mips_24kc_musl/usr/include/sodium.h:17,
                 from build/temp.linux-mips-3.9/_sodium.c:569:
/home/matt/openwrt/staging_dir/target-mips_24kc_musl/usr/include/sodium/crypto_core_ed25519.h:13:8: note: previous declaration of 'crypto_core_ed25519_bytes' was here
 size_t crypto_core_ed25519_bytes(void);
        ^~~~~~~~~~~~~~~~~~~~~~~~~
build/temp.linux-mips-3.9/_sodium.c:589:10: error: 'crypto_core_ed25519_scalarbytes' redeclared as different kind of symbol
 size_t (*crypto_core_ed25519_scalarbytes)(void) = NULL;
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /home/matt/openwrt/staging_dir/target-mips_24kc_musl/usr/include/sodium.h:17,
                 from build/temp.linux-mips-3.9/_sodium.c:569:
/home/matt/openwrt/staging_dir/target-mips_24kc_musl/usr/include/sodium/crypto_core_ed25519.h:25:8: note: previous declaration of 'crypto_core_ed25519_scalarbytes' was here
 size_t crypto_core_ed25519_scalarbytes(void);
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
build/temp.linux-mips-3.9/_sodium.c:590:10: error: 'crypto_core_ed25519_nonreducedscalarbytes' redeclared as different kind of symbol
 size_t (*crypto_core_ed25519_nonreducedscalarbytes)(void) = NULL;
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /home/matt/openwrt/staging_dir/target-mips_24kc_musl/usr/include/sodium.h:17,
                 from build/temp.linux-mips-3.9/_sodium.c:569:
/home/matt/openwrt/staging_dir/target-mips_24kc_musl/usr/include/sodium/crypto_core_ed25519.h:29:8: note: previous declaration of 'crypto_core_ed25519_nonreducedscalarbytes' was here
 size_t crypto_core_ed25519_nonreducedscalarbytes(void);
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

After cherry-picking ccd3b6c ("pynacl: fix build with updated sodium-minimal patch") it now compiles again.

The master branch has pynacl 1.5.0 which supersedes the 1.4.0 in 21.02

@mcbridematt mcbridematt changed the title [21.02] python3-pynacl missing ed25519 patch [21.02] python-pynacl: missing ed25519 patch Mar 29, 2022
@BKPepe
Copy link
Member

BKPepe commented Mar 29, 2022

Fixed by 78aa0f6

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants