Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing support to fold subview ops for vector.store/maskedstore #15575

Closed
hanhanW opened this issue Nov 13, 2023 · 0 comments · Fixed by llvm/llvm-project#72184
Closed

Missing support to fold subview ops for vector.store/maskedstore #15575

hanhanW opened this issue Nov 13, 2023 · 0 comments · Fixed by llvm/llvm-project#72184
Assignees
@Max191
Labels
codegen Shared code generation infrastructure and dialects

Comments

@hanhanW
Copy link
Contributor

hanhanW commented Nov 13, 2023 •
edited
Loading

To repro: iree-opt --fold-memref-alias-ops repro.mlir

https://gist.githubusercontent.com/hanhanW/2872e6d8411f9597483dedd1738d98c1/raw/98f3eaecc927628df3999a64a303752a322549ab/z3.mlir

You will see that there are memref.subview ops not folded away. We need to add support for vector.store/maskedstore ops: https://github.com/llvm/llvm-project/blob/67f15e76ebd23f659168f845f9660d3e5e9c606c/mlir/lib/Dialect/MemRef/Transforms/FoldMemRefAliasOps.cpp#L698-L700

This leads to sub-byte emulation failed because we need to fold all memref.sbuview ops away.
@hanhanW hanhanW added the codegen Shared code generation infrastructure and dialects label Nov 13, 2023
@hanhanW hanhanW mentioned this issue Nov 13, 2023
Open
@hanhanW hanhanW mentioned this issue Nov 14, 2023
Merged
hanhanW pushed a commit to llvm/llvm-project that referenced this issue Nov 14, 2023
@Max191
[mlir] Add vector.store/maskedstore of memref.subview memref alia…
dae3c44 
…s folding (#72184)

Fixes iree-org/iree#15575
@hanhanW hanhanW mentioned this issue Nov 15, 2023
Closed
zahiraam pushed a commit to zahiraam/llvm-project that referenced this issue Nov 20, 2023
@Max191 @zahiraam
[mlir] Add vector.store/maskedstore of memref.subview memref alia…
4c9024d 
…s folding (llvm#72184)

Fixes iree-org/iree#15575
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Max191 Max191

Labels
codegen Shared code generation infrastructure and dialects
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[mlir] Add vector.store/maskedstore of memref.subview memref alias folding Max191/llvm-project
2 participants
@hanhanW @Max191