Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transform dialect custom dispatches make util.func instead of flow.dispatch which seems to run into trouble for slightly complex case #17327

Closed
nirvedhmeshram opened this issue May 9, 2024 · 1 comment · Fixed by #17331
Closed

Transform dialect custom dispatches make util.func instead of flow.dispatch which seems to run into trouble for slightly complex case #17327

nirvedhmeshram opened this issue May 9, 2024 · 1 comment · Fixed by #17331

Comments

@nirvedhmeshram
Copy link
Contributor

In this gist
See the transform_output.mlir and pdl_output.mlir,
It appears the transform output runs into the error with expecting particular type of stream buffers
Here is a full IR dump as well.
@nirvedhmeshram
Copy link
Contributor Author

FYI @MaheshRavishankar
Also @qedawkins (for help on changing the custom dispatch if thats the right thing to do)
and @benvanik if the error in the full dump is a bug.

@nirvedhmeshram nirvedhmeshram changed the title Transform dialect custom dispactches make util.func instead of flow.dispatch which seems to run into trouble for real models Transform dialect custom dispactches make util.func instead of flow.dispatch which seems to run into trouble for slightly complex case May 9, 2024
@nirvedhmeshram nirvedhmeshram changed the title Transform dialect custom dispactches make util.func instead of flow.dispatch which seems to run into trouble for slightly complex case Transform dialect custom dispatches make util.func instead of flow.dispatch which seems to run into trouble for slightly complex case May 9, 2024
@nirvedhmeshram nirvedhmeshram mentioned this issue May 9, 2024
Merged
nirvedhmeshram added a commit that referenced this issue May 10, 2024
@nirvedhmeshram
Transform dialect fix to allow multiple calls to same custom dispatch (…
19c43a5 
…#17331)

Adds an inliner pass that fixes
#17327
Adds a mlp_spec transform dialect script that just matches matmuls and
tests it on the existing two matmul linalg payload IR.
monorimet pushed a commit that referenced this issue May 10, 2024
@nirvedhmeshram @eagarvey-amd
Transform dialect fix to allow multiple calls to same custom dispatch (…
f31b8ff 
…#17331)

Adds an inliner pass that fixes
#17327
Adds a mlp_spec transform dialect script that just matches matmuls and
tests it on the existing two matmul linalg payload IR.
bangtianliu pushed a commit to bangtianliu/iree that referenced this issue Jun 5, 2024
@nirvedhmeshram @bangtianliu
Transform dialect fix to allow multiple calls to same custom dispatch (…
a187fe0 
…iree-org#17331)

Adds an inliner pass that fixes
iree-org#17327
Adds a mlp_spec transform dialect script that just matches matmuls and
tests it on the existing two matmul linalg payload IR.
LLITCHEV pushed a commit to LLITCHEV/iree that referenced this issue Jul 30, 2024
@nirvedhmeshram @LLITCHEV
Transform dialect fix to allow multiple calls to same custom dispatch (…
3ce8c21 
…iree-org#17331)

Adds an inliner pass that fixes
iree-org#17327
Adds a mlp_spec transform dialect script that just matches matmuls and
tests it on the existing two matmul linalg payload IR.

Signed-off-by: Lubo Litchev <lubol@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Transform dialect fix to allow multiple calls to same custom dispatch nirvedhmeshram/iree
1 participant
@nirvedhmeshram