Skip to content
This repository has been archived by the owner on Feb 26, 2020. It is now read-only.

Some "differ in signedness" issues. #19

Closed
GOretZ opened this issue Jun 30, 2010 · 1 comment
Closed

Some "differ in signedness" issues. #19

GOretZ opened this issue Jun 30, 2010 · 1 comment

Comments

@GOretZ
Copy link

GOretZ commented Jun 30, 2010

Got some "differ in signedness" warnings/errors. Here is workaround (worked for me):

  1. module/spl/spl-debug.c
--- module/spl/spl-debug.c      2010-05-25 02:21:35.000000000 +0900
+++ /module/spl/spl-debug.fixed.c       2010-06-30 12:19:56.000000000 +0900
@@ -47,17 +47,17 @@

 unsigned long spl_debug_subsys = ~0; 
 EXPORT_SYMBOL(spl_debug_subsys); 
-module_param(spl_debug_subsys, long, 0644); 
+module_param(spl_debug_subsys, ulong, 0644);
 MODULE_PARM_DESC(spl_debug_subsys, "Subsystem debugging level mask.");

 unsigned long spl_debug_mask = (D_EMERG | D_ERROR | D_WARNING | D_CONSOLE);
 EXPORT_SYMBOL(spl_debug_mask);
-module_param(spl_debug_mask, long, 0644);
+module_param(spl_debug_mask, ulong, 0644);
 MODULE_PARM_DESC(spl_debug_mask, "Debugging level mask.");

 unsigned long spl_debug_printk = D_CANTMASK;
 EXPORT_SYMBOL(spl_debug_printk);
-module_param(spl_debug_printk, long, 0644);
+module_param(spl_debug_printk, ulong, 0644);
 MODULE_PARM_DESC(spl_debug_printk, "Console printk level mask.");

 int spl_debug_mb = -1;
@@ -73,7 +73,7 @@

 unsigned int spl_debug_panic_on_bug = 0;
 EXPORT_SYMBOL(spl_debug_panic_on_bug);
-module_param(spl_debug_panic_on_bug, int, 0644);
+module_param(spl_debug_panic_on_bug, uint, 0644);
 MODULE_PARM_DESC(spl_debug_panic_on_bug, "Panic on BUG");

 static char spl_debug_file_name[PATH_MAX];
  1. module/spl/spl-generic.c
--- module/spl/spl-generic.c    2010-05-25 02:21:35.000000000 +0900
+++ module/spl/spl-generic.fixed.c     2010-06-30 14:10:59.000000000 +0900
@@ -206,7 +206,7 @@
        int rc;                                                         \
                                                                        \
        if (*str == '-') {                                              \
-               rc = ddi_strtou##type(str + 1, endptr, base, result);   \
+               rc = ddi_strto##type(str + 1, endptr, base, result);    \
                if (!rc) {                                              \
                        if (*endptr == str + 1)                         \
                                *endptr = (char *)str;                  \
@@ -214,12 +214,14 @@
                                *result = -*result;                     \
                }                                                       \
        } else {                                                        \
-               rc = ddi_strtou##type(str, endptr, base, result);       \
+               rc = ddi_strto##type(str, endptr, base, result);        \
        }                                                               \
                                                                        \
        return rc;                                                      \
 }

 define_ddi_strtoux(l, unsigned long)
 define_ddi_strtox(l, long)
 define_ddi_strtoux(ll, unsigned long long)
  1. module/spl/spl-thread.c
--- module/spl/spl-thread.c     2010-05-25 02:21:35.000000000 +0900
+++ module/spl/spl-thread.fixed.c      2010-06-30 12:43:19.000000000 +0900
@@ -123,7 +123,7 @@
        tp->tp_state = state;
        tp->tp_pri   = pri;

-       tsk = kthread_create(thread_generic_wrapper, (void *)tp, tp->tp_name);
+       tsk = kthread_create(thread_generic_wrapper, (void *)tp, "%s", tp->tp_name);
        if (IS_ERR(tsk)) {
                CERROR("Failed to create thread: %ld\n", PTR_ERR(tsk));
                RETURN(NULL);
  1. module/spl/spl-vnode.c
--- module/spl/spl-vnode.c      2010-05-25 02:21:35.000000000 +0900
+++ ../spl-0.4.9-1/module/spl/spl-vnode.c       2010-06-30 13:49:05.000000000 +0900
@@ -258,7 +258,7 @@
 static struct dentry *
 vn_lookup_hash(struct nameidata *nd)
 {
-       return lookup_one_len(nd->last.name, nd->nd_dentry, nd->last.len);
+       return lookup_one_len( (const char*) nd->last.name, nd->nd_dentry, nd->last.len);
 } /* lookup_hash() */
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants