Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing update_pages() for zfs_write. #21

Closed
lundman opened this issue May 23, 2013 · 1 comment
Closed

Missing update_pages() for zfs_write. #21

lundman opened this issue May 23, 2013 · 1 comment
Labels

Comments

@lundman
Copy link
Contributor

lundman commented May 23, 2013

Occasionally, zfs_write appears to work but does not actually store any data on disk. export/import will sometimes fix the issue.

I am wondering if it is related to that we do not have update_pages(), as used here;

            ASSERT(tx_bytes <= uio_resid(uio));
            uioskip(uio, tx_bytes);
        }
        if (tx_bytes && vn_has_cached_data(vp)) {
            printf("we should add update_pages()\n");
            //update_pages(vp, woff, tx_bytes, zfsvfs->z_os,
            //      zp->z_id, uio->uio_segflg, tx);
        }

The FreeBSD version looks like;
http://fxr.watson.org/fxr/source/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vnops.c#L441

The Solaris version looks like;
http://fxr.watson.org/fxr/source/common/fs/zfs/zfs_vnops.c?v=OPENSOLARIS#L355

I am unsure what the OSX kernel version would look like.

@lundman
Copy link
Contributor Author

lundman commented May 23, 2013

91442ee

@lundman lundman closed this as completed May 23, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant