Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move functions from steps *.ts files to separated files #185

Closed
pavel-karatsiuba opened this issue Dec 29, 2022 · 1 comment · Fixed by #209
Closed

Move functions from steps *.ts files to separated files #185

pavel-karatsiuba opened this issue Dec 29, 2022 · 1 comment · Fixed by #209
Assignees
@pavel-karatsiuba
Labels
enhancement task
Milestone
2.5.0

Comments

@pavel-karatsiuba
Copy link
Collaborator

pavel-karatsiuba commented Dec 29, 2022 •
edited
Loading

In the files steps/get.ts, steps/transform.ts, and steps/export.ts should stay only executions of the functions.
All functions should be moved to separate files.
This change allows us to make tests for each function.
@kelson42 kelson42 added this to the 2.4.1 milestone Mar 1, 2023
@kelson42
Copy link
Contributor

kelson42 commented Mar 1, 2023 •
edited
Loading

@pavel-karatsiuba Yes, please do so, should be straight. Seems to be a prerequesite for #186.

@kelson42 kelson42 added the task label Mar 1, 2023
@pavel-karatsiuba pavel-karatsiuba mentioned this issue Mar 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pavel-karatsiuba pavel-karatsiuba

Labels
enhancement task
Projects
None yet
Milestone
2.5.0
Development

Successfully merging a pull request may close this issue.

Refactoring source code to make easy testing openzim/phet
2 participants
@kelson42 @pavel-karatsiuba