New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[next-major] Remove metadata conversion from python-libzim #188

Open

benoit74 opened this issue Feb 8, 2024 · 0 comments · May be fixed by #190

Labels

good first issue

benoit74 commented Feb 8, 2024

When adding metadatas, the python-libzim is doing a conversion for some types.

This should be removed because:

the python-libzim is meant to be only a thin wrapper around the C libzim
not all types are handled which is confusing (for instance we missed the conversion of tags list to a string)

This would need a major release since it is a breaking change.

benoit74 mentioned this issue

Fix handling of tag list in Creator.add_metadata (fix #125) openzim/python-scraperlib#126

Merged

rgaudin added the good first issue label

aryanA101a linked a pull request

that will close this issue

remove metadata conversion #190

Draft

rgaudin changed the title ~~Remove metadata conversion from python-libzim~~ [next-major] Remove metadata conversion from python-libzim

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment