Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download released wombat.js instead of embed it in our respository. #146

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

mgautierfr
Copy link
Contributor

Fix #143

Copy link

codecov bot commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ba961c9) 92.08% compared to head (764db58) 92.08%.

Additional details and impacted files
@@            Coverage Diff             @@
##           warc2zim2     #146   +/-   ##
==========================================
  Coverage      92.08%   92.08%           
==========================================
  Files              9        9           
  Lines            720      720           
  Branches         121      117    -4     
==========================================
  Hits             663      663           
  Misses            40       40           
  Partials          17       17           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@benoit74 benoit74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I forced pushed to update the base commit following previous merge.

As discussed, this will be enhanced with the use of hatch-openzim plugin but this is sufficient for now to get rid of the external dependency from this repo.

@benoit74 benoit74 merged commit aca2db3 into warc2zim2 Jan 15, 2024
12 checks passed
@benoit74 benoit74 deleted the wombat_external branch January 15, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants