Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat Wombat as a dependency #143

Closed
rgaudin opened this issue Dec 21, 2023 · 3 comments
Closed

Treat Wombat as a dependency #143

rgaudin opened this issue Dec 21, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@rgaudin
Copy link
Member

rgaudin commented Dec 21, 2023

Wombat.js should not be included in our repo. It should be downloaded from a release instead.

webrecorder/wombat#128 tracks our patch ; if this can't make it upstream, we should patch the downloaded version.

@rgaudin rgaudin added the enhancement New feature or request label Dec 21, 2023
@Jaifroid
Copy link

Presumably this is for v2.0. You're probably aware that wombat.js and wombat worker are included in sw.js as two very long minified strings. This may be irrelevant going forward as we are ditching the Service Worker, but it does bloat sw.js unnecessarily IMO, especially as we currently include wombat.js in every ZIM as well.

(Having said that, my implementation in the Browser Extension extracts and uses the version included in sw.js, so in the unlikely event that this were to be changed, I'd need to know.)

@mgautierfr
Copy link
Contributor

Last version of wombat (https://github.com/webrecorder/wombat/releases/tag/v3.7.0) contains our fix.
So we are good to use (and download) the release instead of embed it in our repo.

@kelson42
Copy link
Contributor

Fixed by #146

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants