Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(#115): fixes grpc module version. #124

Merged
merged 1 commit into from
May 9, 2019
Merged

fix(#115): fixes grpc module version. #124

merged 1 commit into from
May 9, 2019

Conversation

jcchavezs
Copy link
Contributor

This PR fixes the grpc module version as mentioned in #117 (comment)

Ping @jadekler @dmitshur

@ghost ghost assigned jcchavezs Apr 11, 2019
@ghost ghost added the review label Apr 11, 2019
@coveralls
Copy link

coveralls commented Apr 11, 2019 •
edited

Coverage Status

Coverage increased (+6.3%) to 73.213% when pulling eecdde5 on fixes_dep into a9beb3b on master.

basvanbeek
basvanbeek approved these changes May 9, 2019
View reviewed changes
Copy link
Member

@basvanbeek basvanbeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@basvanbeek basvanbeek merged commit c81edde into master May 9, 2019
@ghost ghost removed the review label May 9, 2019
@jcchavezs jcchavezs deleted the fixes_dep branch May 10, 2019 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basvanbeek basvanbeek basvanbeek approved these changes

Assignees

@jcchavezs jcchavezs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jcchavezs @coveralls @basvanbeek