-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FR] Support of junit5 engine #3466
Labels
Comments
Up for a PR?
…On Wed, 27 Jul 2022, 02:41 ZhangJian He, ***@***.***> wrote:
Feature
Now zipkin provides zipkin-junit module, it's very useful in tests.
However, it only works with junit4, I hope it can support junit5 too.
Rationale
This feature benefits all junit5 users.
Example Scenario
People who using junit5 and want to use zipkin-test module
—
Reply to this email directly, view it on GitHub
<#3466>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAXOYAXE5XDGL5ASQ7LZYBTVWCAUXANCNFSM54XY3H6A>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
@jcchavezs Thanks for your reply. I don't think I can do the job. I'm not familiar with zipkin and haven't had enough time lately :) |
@jcchavezs I have created #3467 trying to fix this. waiting for your opinion. Thanks |
I am OOO. @llinder could you please have a look?
…On Sun, 31 Jul 2022, 18:06 ZhangJian He, ***@***.***> wrote:
@jcchavezs <https://github.com/jcchavezs> I have created #3467
<#3467> trying to fix this.
waiting for your opinion. Thanks
—
Reply to this email directly, view it on GitHub
<#3466 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAXOYASCOXSCERVIY7B3LA3VW2QADANCNFSM54XY3H6A>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
closed by #3467 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Feature
Now zipkin provides
zipkin-junit
module, it's very useful in tests. However, it only works with junit4, I hope it can support junit5 too.Rationale
This feature benefits all junit5 users.
Example Scenario
People who using junit5 and want to use
zipkin-test
moduleThe text was updated successfully, but these errors were encountered: