Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Support of junit5 engine #3466

Closed
shoothzj opened this issue Jul 27, 2022 · 5 comments
Closed

[FR] Support of junit5 engine #3466

shoothzj opened this issue Jul 27, 2022 · 5 comments

Comments

@shoothzj
Copy link
Contributor

Feature

Now zipkin provides zipkin-junit module, it's very useful in tests. However, it only works with junit4, I hope it can support junit5 too.

Rationale

This feature benefits all junit5 users.

Example Scenario

People who using junit5 and want to use zipkin-test module

@jcchavezs
Copy link
Contributor

jcchavezs commented Jul 27, 2022 via email

@shoothzj
Copy link
Contributor Author

@jcchavezs Thanks for your reply. I don't think I can do the job. I'm not familiar with zipkin and haven't had enough time lately :)

@shoothzj
Copy link
Contributor Author

@jcchavezs I have created #3467 trying to fix this. waiting for your opinion. Thanks

@jcchavezs
Copy link
Contributor

jcchavezs commented Aug 3, 2022 via email

@shoothzj
Copy link
Contributor Author

closed by #3467

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants