Deprecates EnableZipkinServer to explain custom servers are unsupported #1968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| /** | ||
| * @deprecated Custom servers are possible, but not supported by the community. Please use our |
There was a problem hiding this comment.
here's the deprecation notice
Especially lately, we have had a large number of people having problems with unnecessarily custom servers. Some are due to not knowing Sleuth's stream server is obviated by our rabbit support. Some are due to blogs which unfortunately recommend starting Zipkin in the IDE via a custom server. Through discussion, we decided the easiest way to let users know custom servers are unsupported is by deprecation. Deprecation shows up in the IDE and will alert those doing blogs or otherwise that they are suggesting discouraged practice. It also sends a clear signal to those who need to make custom servers that while doing so is possible, it is something the customizer needs to accept support reponsibility of.
codefromthecrypt
force-pushed
the
deprecate-EnableZipkinServer
branch
from
7f34140
to
8cda3f1
Compare
LGTM
|
thx for having a look, tommy |
abesto
pushed a commit
to abesto/zipkin
that referenced
this pull request
Sep 10, 2019
…ed (openzipkin#1968) Especially lately, we have had a large number of people having problems with unnecessarily custom servers. Some are due to not knowing Sleuth's stream server is obviated by our rabbit support. Some are due to blogs which unfortunately recommend starting Zipkin in the IDE via a custom server. Through discussion, we decided the easiest way to let users know custom servers are unsupported is by deprecation. Deprecation shows up in the IDE and will alert those doing blogs or otherwise that they are suggesting discouraged practice. It also sends a clear signal to those who need to make custom servers that while doing so is possible, it is something the customizer needs to accept support reponsibility of.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Especially lately, we have had a large number of people having problems
with unnecessarily custom servers. Some are due to not knowing Sleuth's
stream server is obviated by our rabbit support. Some are due to blogs
which unfortunately recommend starting Zipkin in the IDE via a custom
server.
Through discussion, we decided the easiest way to let users know custom
servers are unsupported is by deprecation. Deprecation shows up in the
IDE and will alert those doing blogs or otherwise that they are
suggesting discouraged practice. It also sends a clear signal to those
who need to make custom servers that while doing so is possible, it is
something the customizer needs to accept support responsibility of.
See #1962 (comment)