Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecates EnableZipkinServer to explain custom servers are unsupported #1968

Merged
merged 1 commit into from
Mar 28, 2018
Merged

Deprecates EnableZipkinServer to explain custom servers are unsupported #1968

merged 1 commit into from
Mar 28, 2018

Commits on Mar 27, 2018

  1. Deprecates EnableZipkinServer to explain custom servers are unsupported 

    Especially lately, we have had a large number of people having problems
with unnecessarily custom servers. Some are due to not knowing Sleuth's
stream server is obviated by our rabbit support. Some are due to blogs
which unfortunately recommend starting Zipkin in the IDE via a custom
server.

Through discussion, we decided the easiest way to let users know custom
servers are unsupported is by deprecation. Deprecation shows up in the
IDE and will alert those doing blogs or otherwise that they are
suggesting discouraged practice. It also sends a clear signal to those
who need to make custom servers that while doing so is possible, it is
something the customizer needs to accept support reponsibility of.
    Adrian Cole committed Mar 27, 2018
    Configuration menu
    Copy the full SHA
    8cda3f1 View commit details
    Browse the repository at this point in the history