Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent creation of illegal records, eg. multiple CNAMEs of the same name #1

Closed
thomas-pike opened this issue Jan 25, 2017 · 0 comments · Fixed by #3
Closed

Prevent creation of illegal records, eg. multiple CNAMEs of the same name #1

thomas-pike opened this issue Jan 25, 2017 · 0 comments · Fixed by #3

Comments

@thomas-pike
Copy link
Collaborator

CNAMEs are a singleton type and it is not allowed to have one in addition to any other record for the same name.

PowerDNS does not prevent this, and currently neither does the DNS UI, but we should make it detect the conflict and prevent it.
thomas-pike pushed a commit that referenced this issue Feb 1, 2017
Prevent singleton record violations. Fixes #1.
ff7c384 
* Prevents CNAME RRsets having multiple records.
* Prevents CNAME RRsets colliding with other types.
* Also enables deleting of newly added records.
* Enables visual display of entire RRset deletion
thomas-pike pushed a commit that referenced this issue Feb 8, 2017
Prevent singleton record violations. Fixes #1.
0110431 
* Prevents CNAME RRsets having multiple records.
* Prevents CNAME RRsets colliding with other types.
* Also enables deleting of newly added records.
* Enables visual display of entire RRset deletion
@thomas-pike thomas-pike mentioned this issue Feb 8, 2017
Merged
thomas-pike pushed a commit that referenced this issue Feb 8, 2017
Prevent singleton record violations. Fixes #1.
212df30 
* Prevents CNAME RRsets having multiple records.
* Prevents CNAME RRsets colliding with other types.
* Also enables deleting of newly added records.
* Enables visual display of entire RRset deletion
thomas-pike pushed a commit that referenced this issue Feb 8, 2017
Backported to PowerDNS 3 branch:
9b78582 
Prevent singleton record violations. Fixes #1.

* Prevents CNAME RRsets having multiple records.
* Prevents CNAME RRsets colliding with other types.
* Also enables deleting of newly added records.
* Enables visual display of entire RRset deletion
@pasikarkkainen pasikarkkainen mentioned this issue Nov 17, 2017
Closed
@frgalan frgalan mentioned this issue Mar 27, 2018
Open
@billjamzz billjamzz mentioned this issue Sep 13, 2018
Closed
@skkelma skkelma mentioned this issue Oct 9, 2019
Closed
@sdchristen sdchristen mentioned this issue Mar 9, 2020
Closed
uedvt359 added a commit to dvtirol/dns-ui that referenced this issue Nov 23, 2021
@uedvt359
Don't raise and exception when trying to parse date without microseconds
d198fd0 
When SELECTing a date from the postgres database, and that date's
microsecond part is exactly zero, it will be omitted from the string
representation. This causes DateTime::createFromFormat to return false
instead of the date.

To reproduce this bug, create and then edit a zone (so a changeset entry
exists), then set its change_date like so:

    update changeset set change_date = '2021-11-23 10:37:38.000000' where id = 1;

note that when issuing a SELECT, the '.000000' will be automatically
stripped.

[23-Nov-2021 09:40:03 UTC] 1637660403: Error: Call to a member function format() on bool in /var/www/dns-ui/templates/zone.php:687
[23-Nov-2021 09:40:03 UTC] 1637660403: Stack trace:
[23-Nov-2021 09:40:03 UTC] 1637660403: #0 /var/www/dns-ui/pagesection.php(69): include()
[23-Nov-2021 09:40:03 UTC] 1637660403: operasoftware#1 /var/www/dns-ui/pagesection.php(57): PageSection->generate()
[23-Nov-2021 09:40:03 UTC] 1637660403: operasoftware#2 /var/www/dns-ui/templates/base.php(81): PageSection->get()
[23-Nov-2021 09:40:03 UTC] 1637660403: operasoftware#3 /var/www/dns-ui/pagesection.php(69): include('/var/www/dns-ui...')
[23-Nov-2021 09:40:03 UTC] 1637660403: operasoftware#4 /var/www/dns-ui/views/zone.php(321): PageSection->generate()
[23-Nov-2021 09:40:03 UTC] 1637660403: operasoftware#5 /var/www/dns-ui/requesthandler.php(62): require('/var/www/dns-ui...')
[23-Nov-2021 09:40:03 UTC] 1637660403: operasoftware#6 /var/www/dns-ui/public_html/init.php(18): require('/var/www/dns-ui...')
[23-Nov-2021 09:40:03 UTC] 1637660403: operasoftware#7 {main}
@uedvt359 uedvt359 mentioned this issue Nov 23, 2021
Merged
uedvt359 added a commit to dvtirol/dns-ui that referenced this issue Nov 23, 2021
@uedvt359
Don't raise and exception when trying to parse date without microseconds
62a65f0 
When SELECTing a date from the postgres database, and that date's
microsecond part is exactly zero, it will be omitted from the string
representation. This causes DateTime::createFromFormat to return false
instead of the date.

To reproduce this bug, create and then edit a zone (so a changeset entry
exists), then set its change_date like so:

    update changeset set change_date = '2021-11-23 10:37:38.000000' where id = 1;

note that when issuing a SELECT, the '.000000' will be automatically
stripped.

[23-Nov-2021 09:40:03 UTC] 1637660403: Error: Call to a member function format() on bool in /var/www/dns-ui/templates/zone.php:687
[23-Nov-2021 09:40:03 UTC] 1637660403: Stack trace:
[23-Nov-2021 09:40:03 UTC] 1637660403: #0 /var/www/dns-ui/pagesection.php(69): include()
[23-Nov-2021 09:40:03 UTC] 1637660403: operasoftware#1 /var/www/dns-ui/pagesection.php(57): PageSection->generate()
[23-Nov-2021 09:40:03 UTC] 1637660403: operasoftware#2 /var/www/dns-ui/templates/base.php(81): PageSection->get()
[23-Nov-2021 09:40:03 UTC] 1637660403: operasoftware#3 /var/www/dns-ui/pagesection.php(69): include('/var/www/dns-ui...')
[23-Nov-2021 09:40:03 UTC] 1637660403: operasoftware#4 /var/www/dns-ui/views/zone.php(321): PageSection->generate()
[23-Nov-2021 09:40:03 UTC] 1637660403: operasoftware#5 /var/www/dns-ui/requesthandler.php(62): require('/var/www/dns-ui...')
[23-Nov-2021 09:40:03 UTC] 1637660403: operasoftware#6 /var/www/dns-ui/public_html/init.php(18): require('/var/www/dns-ui...')
[23-Nov-2021 09:40:03 UTC] 1637660403: operasoftware#7 {main}
sipopo added a commit to sipopo/dns-ui that referenced this issue Aug 29, 2022
@sipopo
fix php81 (ErrorException: unserialize(): Passing null to parameter o…
1e122e1 
…perasoftware#1 () of type string is deprecated)

Signed-off-by: Sergey V. Osipov <sipopo@yandex.ru>
@sipopo sipopo mentioned this issue Aug 29, 2022
Merged
sipopo added a commit to sipopo/dns-ui that referenced this issue Aug 29, 2022
@sipopo
fix php81 (ErrorException: unserialize(): Passing null to parameter o…
4c9b597 
…perasoftware#1 () of type string is deprecated)

Signed-off-by: Sergey V. Osipov <sipopo@yandex.ru>
thomas-pike pushed a commit that referenced this issue Aug 30, 2022
@sipopo
fix php81 (ErrorException: unserialize(): Passing null to parameter #… (
7c5886d 
#193)

* fix php81 (ErrorException: unserialize(): Passing null to parameter #1 () of type string is deprecated)

Signed-off-by: Sergey V. Osipov <sipopo@yandex.ru>

* better solution

Signed-off-by: Sergey V. Osipov <sipopo@yandex.ru>

Signed-off-by: Sergey V. Osipov <sipopo@yandex.ru>
@sipopo sipopo mentioned this issue Feb 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Singleton enforcement, improved delete and idn function cleanup operasoftware/dns-ui
1 participant
@thomas-pike