Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create/Update prometheus monitors for different ODH components #11

Closed
3 of 6 tasks
HumairAK opened this issue Oct 28, 2020 · 4 comments
Closed
3 of 6 tasks

Create/Update prometheus monitors for different ODH components #11

HumairAK opened this issue Oct 28, 2020 · 4 comments

Comments

@HumairAK
Copy link
Member

HumairAK commented Oct 28, 2020

First confirm with odh (likely via issue upstream) if there are plans to add such service monitors and the eta. Based on this feedback, we should discuss here whether we need to proceed with adding our own and sending them upstream.

[anishasthana] At a minimum, we should update/create monitoring for the following:

  • Jupyterhub
  • Kafka
  • Superset
  • Data Catalog (once it's in)
  • Argo
  • Airflow
@anishasthana
Copy link
Member

Can we split this into individual issues per component? Would be easier to track progress that way imo.

@anishasthana
Copy link
Member

@HumairAK Let's rename the issue to say "Create prometheus monitors for different ODH components". In some cases, we will need to use pod monitors

@anishasthana
Copy link
Member

Also, kafka monitoring was added in opendatahub-io/odh-manifests#230 :-)

@HumairAK HumairAK changed the title Create the service monitors for different odh components Create prometheus monitors for different ODH components Nov 9, 2020
@anishasthana anishasthana changed the title Create prometheus monitors for different ODH components Create/Update prometheus monitors for different ODH components Nov 9, 2020
@HumairAK HumairAK added the Epic label Nov 12, 2020
@HumairAK
Copy link
Member Author

The strategy has evolved a bit, we'll be using one service monitor for monitoring odh components, see here and the adr here for more info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants