Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separating environment specific details #36

Closed
HumairAK opened this issue Nov 25, 2020 · 2 comments · Fixed by #46
Closed

Separating environment specific details #36

HumairAK opened this issue Nov 25, 2020 · 2 comments · Fixed by #46
Assignees
@martinpovolny @durandom @anishasthana @hemajv @tumido @4n4nd
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@HumairAK
Copy link
Member

HumairAK commented Nov 25, 2020 •
edited
Loading

We are already starting to see some moc specific implementation (e.g. storage class for JH #22 and possibly superset #35). We need a way to separate these out from general deployments.

We could separate them out into bases/overlays (where overlays have folders like moc and quicklab). The problem is then our argocd-apps repo will become environment specific (since we specify a path). As a solution we could also extend the base/overlays structure to the argocd-apps repo. That's one suggestion, open to other ideas.
@tumido tumido mentioned this issue Nov 30, 2020
Merged
@tumido
Copy link
Member

tumido commented Nov 30, 2020

I kinda agree with you. It's not pretty but it sounds like a viable strategy and I have nothing better in my sleeve right now since I was thinking the same. 🙂

@goern
Copy link
Member

goern commented Nov 30, 2020

/kind feature

@sesheta sesheta added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 30, 2020
@tumido tumido mentioned this issue Dec 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@martinpovolny martinpovolny

@durandom durandom

@anishasthana anishasthana

@hemajv hemajv

@tumido tumido

@4n4nd 4n4nd

Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Restructure to a per-downstream overlays tumido/apps
9 participants
@martinpovolny @durandom @goern @anishasthana @hemajv @tumido @HumairAK @4n4nd @sesheta