Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add onboarding docs and update ADRs #189

Merged
merged 1 commit into from
Jan 25, 2021
Merged

feat: Add onboarding docs and update ADRs #189

merged 1 commit into from
Jan 25, 2021

Conversation

tumido
Copy link
Member

@tumido tumido commented Jan 22, 2021

Signed-off-by: Tomas Coufal <tcoufal@redhat.com>
@tumido
Copy link
Member Author

tumido commented Jan 22, 2021

/hold wait for the pending content PRs

@sesheta sesheta added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jan 22, 2021
@oindrillac
Copy link
Member

/hold wait for the pending content PRs

@tumido is this PR ready to unhold?

@tumido
Copy link
Member Author

tumido commented Jan 25, 2021

@oindrillac you are 💯 right! It is indeed 👍

/unhold

@sesheta sesheta removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 25, 2021
Copy link
Member

@oindrillac oindrillac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ⚡👍

@sesheta
Copy link
Member

sesheta commented Jan 25, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HumairAK, oindrillac

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 25, 2021
@sesheta sesheta merged commit e40322f into operate-first:master Jan 25, 2021
cfchase pushed a commit that referenced this pull request Jan 25, 2021
Signed-off-by: Tomas Coufal <tcoufal@redhat.com>
quaid pushed a commit to quaid/operate-first.github.io-old that referenced this pull request May 13, 2022
Signed-off-by: Tomas Coufal <tcoufal@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants