Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add onboarding docs for rook #49

Merged
merged 1 commit into from
Jan 22, 2021

Conversation

tumido
Copy link
Member

@tumido tumido commented Jan 22, 2021

Resolves #48

Signed-off-by: Tomas Coufal <tcoufal@redhat.com>
@sesheta sesheta added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 22, 2021
@tumido tumido requested a review from HumairAK January 22, 2021 14:25
@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 22, 2021
Copy link

@4n4nd 4n4nd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! 🚢

@sesheta
Copy link
Member

sesheta commented Jan 22, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 4n4nd, HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@HumairAK HumairAK merged commit f904922 into operate-first:main Jan 22, 2021
@4n4nd
Copy link

4n4nd commented Jan 22, 2021

@tumido did you get a chance to look into CephObjectStoreUser CR to limit S3 user permissions?

@tumido
Copy link
Member Author

tumido commented Jan 25, 2021

@4n4nd it seems it doesn't work. But you should be able to set policies on already created buckets. Let's have an issue for it, though. This seems like a bigger thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK] Create user docs for S3/Ceph/Rook usage
4 participants