-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version in CSV name should match the version field #237
Comments
I'm not sure it makes sense to do this for the entire version string. All kubernetes resource names have a set of character and length restrictions that make them incompatible with semver strings. See: https://kubernetes.io/docs/concepts/overview/working-with-objects/names/#names Compare that to the semver spec, for example build metadata which includes In general, the convention operators have been following has been:
I think it could make sense to parse the csv |
It shows for me that what we can do here is check if the Note that the PR: #238 shows block this one. |
@ryantking wdyt? Could you give us a hand with this one? |
validation that exists today in the operatorhub test suite only checks that the csv name is "name + a version" not "name + the version field"
api/pkg/validation/internal/operatorhub.go
Line 247 in a7ebc81
This means teams can release
myoperator.v.1.0.0
withversion: 1.0.1
which should not pass validation.The text was updated successfully, but these errors were encountered: