Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(registry) Update the addDependencies to add requiredAPIs #272

Closed
wants to merge 1 commit into from
Closed

fix(registry) Update the addDependencies to add requiredAPIs #272

wants to merge 1 commit into from

Conversation

dinhxuanvu
Copy link
Member

RequiredAPIs information in CSV will be extracted and added to
dependencies table as gvk type dependency when operator is loaded
into the registry DB.

Signed-off-by: Vu Dinh vdinh@redhat.com

Description of the change:

Motivation for the change:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 15, 2020
@dinhxuanvu
Copy link
Member Author

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 15, 2020
ecordell
ecordell approved these changes Apr 15, 2020
View reviewed changes
Copy link
Member

@ecordell ecordell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 15, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dinhxuanvu, ecordell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [dinhxuanvu,ecordell]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ecordell ecordell mentioned this pull request Apr 15, 2020
Closed
@Bowenislandsong
Copy link
Member

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 15, 2020
@Bowenislandsong
Copy link
Member

/retest

1 similar comment
@ecordell
Copy link
Member

/retest

@dinhxuanvu dinhxuanvu mentioned this pull request Apr 15, 2020
Closed
5 tasks
@benluddy
Copy link
Contributor

/retest

2 similar comments
@benluddy
Copy link
Contributor

/retest

@benluddy
Copy link
Contributor

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@dinhxuanvu
fix(registry) Update the addDependencies to add requiredAPIs
7eccfcf 
RequiredAPIs information in CSV will be extracted and added to
dependencies table as gvk type dependency when operator is loaded
into the registry DB.

Signed-off-by: Vu Dinh <vdinh@redhat.com>
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 16, 2020
@Bowenislandsong
Copy link
Member

/lgtm
Since this is a rebase, no hold necessary.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 16, 2020
@dinhxuanvu
Copy link
Member Author

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link

@dinhxuanvu: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws 7eccfcf link /test e2e-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dinhxuanvu dinhxuanvu mentioned this pull request Apr 16, 2020
Merged
5 tasks
@dinhxuanvu
Copy link
Member Author

Replaced by #280

@dinhxuanvu dinhxuanvu closed this Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ecordell ecordell ecordell approved these changes

@gallettilance gallettilance Awaiting requested review from gallettilance

@njhale njhale Awaiting requested review from njhale

Assignees

@ecordell ecordell

@Bowenislandsong Bowenislandsong

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@dinhxuanvu @openshift-ci-robot @Bowenislandsong @ecordell @benluddy @openshift-bot