Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(query): ListBundles returns all bundles even without dependencies #274

Closed
wants to merge 1 commit into from
Closed

fix(query): ListBundles returns all bundles even without dependencies #274

wants to merge 1 commit into from

Conversation

dinhxuanvu
Copy link
Member

ListBundles query uses INNER JOIN which only intersection meaning it only
returns bundles with dependencies. Switching to LEFT OUTER JOIN to return
all bundles with or without dependencies.

Signed-off-by: Vu Dinh vdinh@redhat.com

Description of the change:

Motivation for the change:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

@dinhxuanvu
Copy link
Member Author

/hold

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Apr 15, 2020
@dinhxuanvu dinhxuanvu mentioned this pull request Apr 15, 2020
Closed
ecordell
ecordell reviewed Apr 15, 2020
View reviewed changes
Copy link
Member

@ecordell ecordell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

pkg/registry/populator_test.go Outdated Show resolved Hide resolved
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dinhxuanvu, ecordell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [dinhxuanvu,ecordell]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dinhxuanvu
Copy link
Member Author

dinhxuanvu commented Apr 15, 2020 •
edited

Actually, this PR can be merged independently without #272 so go ahead and remove /hold when ready. Thanks @ecordell @benluddy

@benluddy
Copy link
Contributor

/lgtm

Thanks!

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 16, 2020
@njhale
Copy link
Member

njhale commented Apr 16, 2020

/retest

@kevinrizza
Copy link
Member

/lgtm

@dinhxuanvu
Copy link
Member Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 16, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 16, 2020
@dinhxuanvu
fix(query): ListBundles returns all bundles even without dependencies
f04ed90 
ListBundles query uses INNER JOIN which only intersection meaning it only
returns bundles with dependencies. Switching to LEFT OUTER JOIN to return
all bundles with or without dependencies.

Signed-off-by: Vu Dinh <vdinh@redhat.com>
@kevinrizza
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 16, 2020
@dinhxuanvu
Copy link
Member Author

/retest

1 similar comment
@dinhxuanvu
Copy link
Member Author

/retest

@openshift-ci-robot
Copy link

@dinhxuanvu: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws f04ed90 link /test e2e-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dinhxuanvu dinhxuanvu mentioned this pull request Apr 16, 2020
Merged
5 tasks
@dinhxuanvu
Copy link
Member Author

Replaced by #280

@dinhxuanvu dinhxuanvu closed this Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ecordell ecordell ecordell left review comments

@benluddy benluddy Awaiting requested review from benluddy

@gallettilance gallettilance Awaiting requested review from gallettilance

@kevinrizza kevinrizza Awaiting requested review from kevinrizza

Assignees

@benluddy benluddy

@kevinrizza kevinrizza

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@dinhxuanvu @openshift-ci-robot @benluddy @njhale @kevinrizza @openshift-bot @ecordell