Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(registry): Fix dependency load/query and add ListBundles to registry client #280

Merged
merged 3 commits into from Apr 16, 2020

Conversation

dinhxuanvu
Copy link
Member

Description of the change:
Combination PR for #272 #273 and #274

Motivation for the change:
Fix addDependencies method to load requiredAPIs from bundle.
Fix ListBundles query to return all bundles with or without dependencies
Add ListBundles() to registry client.

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

dinhxuanvu and others added 3 commits April 16, 2020 17:48
RequiredAPIs information in CSV will be extracted and added to
dependencies table as gvk type dependency when operator is loaded
into the registry DB.

Signed-off-by: Vu Dinh <vdinh@redhat.com>
ListBundles query uses INNER JOIN which only intersection meaning it only
returns bundles with dependencies. Switching to LEFT OUTER JOIN to return
all bundles with or without dependencies.

Signed-off-by: Vu Dinh <vdinh@redhat.com>
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dinhxuanvu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kevinrizza
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 16, 2020
@ecordell
Copy link
Member

/lgtm

@openshift-ci-robot
Copy link

@dinhxuanvu: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws c173bd6 link /test e2e-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ecordell
Copy link
Member

passed upstream ci, e2e-aws is broken at the moment.

@ecordell ecordell merged commit 96b4181 into operator-framework:master Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants