Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ListBundles to the client interface. #273

Closed
wants to merge 2 commits into from
Closed

Add ListBundles to the client interface. #273

wants to merge 2 commits into from

Conversation

benluddy
Copy link
Contributor

No description provided.

@kevinrizza
Copy link
Member

/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benluddy, kevinrizza

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 15, 2020
ecordell
ecordell reviewed Apr 15, 2020
View reviewed changes
Copy link
Member

@ecordell ecordell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a quick test in https://github.com/operator-framework/operator-registry/blob/master/pkg/server/server_test.go?

@benluddy
Copy link
Contributor Author

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 15, 2020
@dinhxuanvu
Copy link
Member

Waiting for PR #274 to merge first so it can fix the query bug.

@benluddy
Copy link
Contributor Author

Holding this until #274 merges.

@dinhxuanvu @benluddy
fix(query): ListBundles returns all bundles even without dependencies
dfbb9a8 
ListBundles query uses INNER JOIN which only intersection meaning it only
returns bundles with dependencies. Switching to LEFT OUTER JOIN to return
all bundles with or without dependencies.

Signed-off-by: Vu Dinh <vdinh@redhat.com>
@openshift-ci-robot
Copy link

@benluddy: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws ff7cd8f link /test e2e-aws
ci/prow/images ff7cd8f link /test images

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dinhxuanvu dinhxuanvu mentioned this pull request Apr 16, 2020
Merged
5 tasks
@dinhxuanvu
Copy link
Member

Replaced by #280

@dinhxuanvu dinhxuanvu closed this Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ecordell ecordell ecordell left review comments

@exdx exdx Awaiting requested review from exdx

@njhale njhale Awaiting requested review from njhale

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@benluddy @kevinrizza @openshift-ci-robot @dinhxuanvu @ecordell