Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix okconfig listhosts returning empty output #63

Merged
merged 1 commit into from
Jul 2, 2014

Conversation

palli
Copy link
Contributor

@palli palli commented Jun 28, 2014

No description provided.

@tomas-edwardsson
Copy link
Contributor

Confirmed, works. I would love some way of testing this stuff. I've been mulling over if moving usr/bin/okconfig code to okconfig/cli.py and the one in usr/bin/okconfig becomes something like:

from okconfig.cli import runcli

runcli()

This way we have better access to testing function from the CLI. Thoughts?

@palli
Copy link
Contributor Author

palli commented Jun 29, 2014

Sounds good to me if you want to add some tests. Use git mv to preserve
code history.
On Jun 29, 2014 4:31 PM, "Tomas Edwardsson" notifications@github.com
wrote:

Confirmed, works. I would love some way of testing this stuff. I've been
mulling over if moving usr/bin/okconfig code to okconfig/cli.py and the one
in usr/bin/okconfig becomes something like:

from okconfig.cli import runcli

runcli()

This way we have better access to testing function from the CLI. Thoughts?


Reply to this email directly or view it on GitHub
#63 (comment).

@palli
Copy link
Contributor Author

palli commented Jul 2, 2014

Can we merge this ?

tomas-edwardsson added a commit that referenced this pull request Jul 2, 2014
Fix okconfig listhosts returning empty output
@tomas-edwardsson tomas-edwardsson merged commit b97e2c5 into master Jul 2, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants