[storage] [lint] Start enforcing lint errors #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
name, count, comments, ... see opiproject#195 Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
glimchb
commented
Nov 9, 2022
| @@ -109,3 +83,27 @@ message NVMfRemoteControllerStatsResponse { | |||
| string stats = 2; | |||
| } | |||
|
|
|||
| enum NvmeTransportType { | |||
There was a problem hiding this comment.
glimchb
commented
Nov 9, 2022
| @@ -192,13 +188,13 @@ message NVMeNamespace { | |||
|
|
|||
| // Size/Capacity of the namespace in blocks, size in bytes will | |||
| // be BlockSize x NumBlocks. | |||
| int64 num_blocks = 6; | |||
| int64 blocks_count = 6; | |||
There was a problem hiding this comment.
glimchb
commented
Nov 9, 2022
| @@ -30,11 +29,10 @@ message AioController { | |||
| // handle will be returned with created object | |||
| common.v1.ObjectKey handle = 1; | |||
|
|
|||
| string name = 2; | |||
| int64 block_size = 3; | |||
| int64 num_blocks = 4; | |||
There was a problem hiding this comment.
glimchb
commented
Nov 9, 2022
| @@ -25,10 +24,9 @@ service NullDebugService { | |||
|
|
|||
| message NullDebug { | |||
| int64 id = 1; | |||
| string name = 2; | |||
| int64 block_size = 3; | |||
| int64 num_blocks = 4; | |||
There was a problem hiding this comment.
glimchb
commented
Nov 9, 2022
| @@ -33,31 +30,8 @@ message NVMfRemoteController { | |||
| bool hdgst = 7; | |||
| bool ddgst = 8; | |||
| NvmeMultipath multipath = 9; | |||
| int64 num_io_queues = 10; | |||
There was a problem hiding this comment.
glimchb
commented
Nov 9, 2022
| @@ -24,7 +24,7 @@ message NvmeControllerPciId { | |||
| int32 device = 2; | |||
|
|
|||
| // Physical function, always set to 0 in current model | |||
| int32 function = 3; | |||
There was a problem hiding this comment.
glimchb
commented
Nov 9, 2022
| @@ -152,7 +149,7 @@ message NVMeController { | |||
| // If not set, the xPU will provide a default. | |||
| int32 max_nsq = 5; | |||
|
|
|||
| // maximum number of host completion queues allowed. Optional. | |||
There was a problem hiding this comment.
glimchb
commented
Nov 9, 2022
|
|
||
| // Globally unique identifier for the namespace | ||
| string nguid = 7; | ||
|
|
||
| // 64bit Extended unique identifier for the namespace | ||
| // mandatory if guid is not specified, optional otherwise | ||
| // mandatory if guid is not specified |
There was a problem hiding this comment.
glimchb
added
Storage
mestery
approved these changes
Nov 9, 2022
seroyer
approved these changes
Nov 9, 2022
| @@ -15,5 +15,6 @@ all: | |||
| curl -kL https://github.com/googleapis/googleapis/archive/master.tar.gz | tar --strip=1 -zxvf - googleapis-master/google/api | |||
| mv google "${PWD}"/v1alpha1/ | |||
| docker run --user=$$(id -u):$$(id -g) --rm --entrypoint=sh -v "${PWD}/../common/v1":/common -v "${PWD}"/v1alpha1/:/out -w /out ghcr.io/docker-multiarch/google-api-linter:1.36.0 -c "api-linter -I /common /out/*.proto --output-format summary" | |||
| docker run --user=$$(id -u):$$(id -g) --rm --entrypoint=sh -v "${PWD}/../common/v1":/common -v "${PWD}"/v1alpha1/:/out -w /out ghcr.io/docker-multiarch/google-api-linter:1.36.0 -c "api-linter -I /common /out/*.proto --output-format github --disable-rule=core::0192::has-comments --disable-rule=core::0136 --disable-rule=core::0127 --set-exit-status" | |||
There was a problem hiding this comment.
Might be nice to document the rules being ignored and why. But not a blocker.
There was a problem hiding this comment.
just wanted to start enforcing rules, so ignore is temp thing, eventually nothing will be ignored, thanks @seroyer
glimchb
added a commit
to opiproject/opi-spdk-bridge
that referenced
this pull request
Nov 9, 2022
see opiproject/opi-api#197 see opiproject/opi-api#199 Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
glimchb
added a commit
to opiproject/opi-spdk-bridge
that referenced
this pull request
Nov 9, 2022
see opiproject/opi-api#197 see opiproject/opi-api#199 Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
glimchb
added a commit
to opiproject/opi-spdk-bridge
that referenced
this pull request
Nov 9, 2022
see opiproject/opi-api#197 see opiproject/opi-api#199 Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
glimchb
added a commit
to opiproject/opi-spdk-bridge
that referenced
this pull request
Nov 9, 2022
see opiproject/opi-api#197 see opiproject/opi-api#199 Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name, count, comments, ... see #195
Signed-off-by: Boris Glimcher Boris.Glimcher@emc.com