Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing Google AIP api linter #195

Closed
glimchb opened this issue Nov 8, 2022 · 6 comments
Closed

Fixing Google AIP api linter #195

glimchb opened this issue Nov 8, 2022 · 6 comments
Labels
good first issue Good for newcomers Storage APIs or code related to storage area

Comments

@glimchb
Copy link
Member

glimchb commented Nov 8, 2022 •
edited
Loading 

docker run --user=$(id -u):$(id -g) --rm -v "opiproject/opi-api/storage"/v1alpha1/:/out -w /out --entrypoint=sh ghcr.io/docker-multiarch/google-api-linter:1.36.0 -c "api-linter /out/*.proto --output-format summary"
+--------------------------------------+------------------+----------------+
|                 RULE                 | TOTAL VIOLATIONS | VIOLATED FILES |
+--------------------------------------+------------------+----------------+
| core::0191::file-layout              |                1 |              1 |
| core::0140::reserved-words           |                1 |              1 |
| core::0191::java-outer-classname     |                1 |              1 |
| core::0142::time-field-type          |                2 |              1 |
| core::0203::optional                 |                2 |              1 |
| core::0126::unspecified              |                3 |              1 |
| core::0141::count-suffix             |                4 |              4 |
| core::0123::resource-annotation      |                4 |              4 |
| core::0192::only-leading-comments    |                6 |              6 |
| core::0136::http-method              |               12 |              3 |
| core::0136::http-body                |               12 |              3 |
| core::0127::resource-name-extraction |               12 |              3 |
| core::0141::forbidden-types          |               14 |              2 |
| core::0127::http-annotation          |               24 |              6 |
| core::0136::http-uri-suffix          |               30 |              3 |
| core::0192::has-comments             |              282 |              6 |
+--------------------------------------+------------------+----------------+
Linted 13 proto files
@glimchb glimchb added good first issue Good for newcomers Storage APIs or code related to storage area labels Nov 8, 2022
glimchb added a commit to glimchb/opi-api that referenced this issue Nov 8, 2022
@glimchb
Fixing linters opiproject#195
4a93077 
Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
@glimchb glimchb mentioned this issue Nov 8, 2022
Merged
glimchb added a commit that referenced this issue Nov 8, 2022
@glimchb
Fixing linters #195
0e0f996 
Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
glimchb added a commit to glimchb/opi-api that referenced this issue Nov 8, 2022
@glimchb
[storage] [lint] Start enforcing lint errors
c6c60bd 
name, count, comments, ... see opiproject#195

Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
@glimchb glimchb mentioned this issue Nov 8, 2022
Merged
glimchb added a commit that referenced this issue Nov 9, 2022
@glimchb
[storage] [lint] Start enforcing lint errors
ae645e3 
name, count, comments, ... see #195

Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
@glimchb
Copy link
Member Author

glimchb commented Nov 10, 2022 •
edited
Loading

with latest merged code https://github.com/opiproject/opi-api/blob/main/storage/Makefile#L18

	docker run --user=$$(id -u):$$(id -g) --rm --entrypoint=sh -v "${PWD}/../common/v1":/common -v "${PWD}"/v1alpha1/:/out -w /out ghcr.io/docker-multiarch/google-api-linter:1.36.0 -c "api-linter -I /common /out/*.proto --output-format github --disable-rule=core::0192::has-comments --disable-rule=core::0136 --disable-rule=core::0127 --set-exit-status"

still ignoring 3 rules that need to re-enable them:

  • core::0192::has-comments
  • core::0136
  • core::0127
    which are:
| core::0136::http-method              |               12 |              3 |
| core::0136::http-body                |               12 |              3 |
| core::0127::resource-name-extraction |               12 |              3 |
| core::0127::http-annotation          |               24 |              6 |
| core::0136::http-uri-suffix          |               30 |              3 |
| core::0192::has-comments             |              282 |              6 |

@glimchb glimchb mentioned this issue Nov 10, 2022
Merged
@glimchb
Copy link
Member Author

glimchb commented Nov 10, 2022

after #202

+--------------------------------------------+------------------+----------------+
|                    RULE                    | TOTAL VIOLATIONS | VIOLATED FILES |
+--------------------------------------------+------------------+----------------+
| core::0133::http-body                      |                3 |              2 |
| core::0132::request-unknown-fields         |                4 |              2 |
| core::0135::request-name-required          |                6 |              3 |
| core::0133::request-resource-behavior      |                6 |              3 |
| core::0134::request-unknown-fields         |                6 |              3 |
| core::0134::request-mask-required          |                6 |              3 |
| core::0133::request-parent-required        |                6 |              3 |
| core::0134::method-signature               |                6 |              3 |
| core::0134::http-body                      |                6 |              3 |
| core::0158::request-page-size-field        |                6 |              3 |
| core::0131::method-signature               |                6 |              3 |
| core::0131::request-name-required          |                6 |              3 |
| core::0134::request-resource-field         |                6 |              3 |
| core::0133::request-resource-field         |                6 |              3 |
| core::0131::http-uri-name                  |                6 |              3 |
| core::0133::http-uri-parent                |                6 |              3 |
| core::0132::request-parent-required        |                6 |              3 |
| core::0158::request-page-token-field       |                6 |              3 |
| core::0158::response-next-page-token-field |                6 |              3 |
| core::0135::method-signature               |                6 |              3 |
| core::0158::response-plural-first-field    |                6 |              3 |
| core::0134::http-uri-name                  |                6 |              3 |
| core::0132::response-unknown-fields        |                6 |              3 |
| core::0133::method-signature               |                6 |              3 |
| core::0135::http-uri-name                  |                6 |              3 |
| core::0131::request-unknown-fields         |                7 |              3 |
| core::0135::request-unknown-fields         |                7 |              3 |
| core::0127::resource-name-extraction       |               12 |              3 |
| core::0127::http-annotation                |               24 |              6 |
| core::0192::has-comments                   |              281 |              6 |
+--------------------------------------------+------------------+----------------+

@glimchb
Copy link
Member Author

glimchb commented Nov 11, 2022

0158 fixed by #203

@glimchb
Copy link
Member Author

glimchb commented Dec 8, 2022 •
edited
Loading

Fixed by #218 :

  • [storage] [lint] Re-enable rule=core::0135
  • [storage] [lint] Re-enable rule=core::0131
  • [storage] [lint] Re-enable rule=core::0132
  • [storage] [lint] Re-enable rule=core::0134
  • [storage] [lint] Re-enable rule=core::0133

Now left:

+--------------------------------------+------------------+----------------+
|                 RULE                 | TOTAL VIOLATIONS | VIOLATED FILES |
+--------------------------------------+------------------+----------------+
| core::0156::forbidden-methods        |               11 |              7 |
| core::0127::http-annotation          |               12 |              7 |
| core::0127::resource-name-extraction |               22 |              7 |
| core::0192::has-comments             |              380 |              8 |
+--------------------------------------+------------------+----------------+

survinderpal added a commit to survinderpal/opi-api that referenced this issue Mar 31, 2023
@survinderpal
Squashed commit of the following:
30db213 
commit 625e66a59b8a66d3ddc0cf3d2f2d72328f892b6e
Author: Maryam Tahhan <mtahhan@redhat.com>
Date:   Fri Mar 24 10:12:45 2023 +0000

    opi-api: slides from the March 23, 2023 meeting

    Signed-off-by: Maryam Tahhan <mtahhan@redhat.com>

commit 26d7a341e5cfbb838275da7863ca723d880d3c3f
Author: Boris Glimcher <Boris.Glimcher@emc.com>
Date:   Mon Mar 20 22:13:51 2023 +0200

    [storage] auto-generate protos

    Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>

commit f186cccc5e2d58061cc257b95f4fa24771c13667
Author: Boris Glimcher <Boris.Glimcher@emc.com>
Date:   Mon Mar 20 22:09:46 2023 +0200

    Following Google AIP-135 - Standard methods: Delete

    Adding `allow_missing` bool field

    see https://google.aip.dev/135#delete-if-existing

    Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>

commit 0605e35f1e298f962419eb74e622f65b32eb99e9
Author: Mark Sanders <Mark_S_Sanders@dell.com>
Date:   Fri Mar 17 11:40:02 2023 -0400

    Meeting topics and Notes for March 16

    Signed-off-by: Mark Sanders <Mark_S_Sanders@dell.com>

commit 05176c3f77503bd6eb3b8b27c8cf2f04f66e3863
Author: Mark Sanders <Mark_S_Sanders@dell.com>
Date:   Thu Mar 9 15:02:02 2023 -0500

    March 2nd and 9th Meeting Topics and Recording

    Signed-off-by: Mark Sanders <Mark_S_Sanders@dell.com>

commit 4d50cc36139e8d64884a4c393b5992b3f57ac35c
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Wed Mar 8 18:10:40 2023 +0000

    Update docker/setup-buildx-action digest to f1dc97e

commit 328ef45a14b77d8c0abf58af4c805c5bab51332c
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Fri Mar 3 13:59:05 2023 +0000

    Update docker/setup-buildx-action digest to 03a7a3d

commit 84a85a3b30820949555a60600dc9d21e1189ee24
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Thu Mar 2 21:50:48 2023 +0000

    Update docker/setup-buildx-action digest to 774ea5c

commit cfabce5c411a51710e2cf89a9357381ddbb68160
Author: Mark Sanders <Mark_S_Sanders@dell.com>
Date:   Fri Feb 24 17:30:28 2023 -0500

    Meeting Topics and Minutes for Feb 23

    Signed-off-by: Mark Sanders <Mark_S_Sanders@dell.com>

commit 4bbc7d19755f4c46a89946e4406ed4000a2a31b9
Author: Vipin Jain <jainvipin@gmail.com>
Date:   Mon Feb 20 14:52:53 2023 -0800

    add autogenerated files from cloud rpc apis

    Signed-off-by: Vipin Jain <jainvipin@gmail.com>

commit 277a40abe35cd81fc835c30e42a1e52a9102e508
Author: Vipin Jain <jainvipin@gmail.com>
Date:   Mon Feb 20 11:31:01 2023 -0800

    document optional apis explicitly

    Signed-off-by: Vipin Jain <jainvipin@gmail.com>

commit 759ec0d04e0056816f86a8516ce91f09b1d2dc4b
Author: Vipin Jain <jainvipin@gmail.com>
Date:   Fri Feb 17 16:23:55 2023 -0800

    rpc for cloud protos

    Signed-off-by: Vipin Jain <jainvipin@gmail.com>

commit 136a80b2cf1a1374991783bc1c958190a77d50a0
Author: Boris Glimcher <Boris.Glimcher@emc.com>
Date:   Fri Feb 17 23:19:37 2023 +0200

    auto-generate protos

    Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>

commit 3afcc11ed35a7dd112af6d30339ac26f4a546b1a
Author: Boris Glimcher <Boris.Glimcher@emc.com>
Date:   Fri Feb 17 23:19:37 2023 +0200

    auto-generate protos

    Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>

commit db808e9b9f9204212863ae726697329cb22a2298
Author: Boris Glimcher <Boris.Glimcher@emc.com>
Date:   Fri Feb 17 22:37:39 2023 +0200

    Add PCI device information

    Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>

commit 6b5ca335938ef0b2fe523f42b000853e9833cb2d
Author: Mark Sanders <Mark_S_Sanders@dell.com>
Date:   Thu Feb 16 18:41:15 2023 -0500

    Feb 16 Topics and Recording notes

    Signed-off-by: Mark Sanders <Mark_S_Sanders@dell.com>

commit 2cf625ef7bed07b51a8635a9202e7325cdcf92f9
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Mon Feb 13 12:46:36 2023 +0000

    Update docker/setup-buildx-action digest to 2dd22fa

commit 993fdd8940caef39f630be383b8c179b365b1b0e
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Fri Feb 10 16:30:30 2023 +0000

    Update docker/setup-buildx-action digest to f03ac48

commit 69ca2954569d944bec232b16722dfb87ca3fe647
Author: Vipin Jain <jainvipin@gmail.com>
Date:   Fri Feb 10 07:24:07 2023 -0800

    add missing generated files

    Signed-off-by: Vipin Jain <jainvipin@gmail.com>

commit 49817ff570385fefe4e48f6f6cca343de098795f
Author: Mark Sanders <Mark_S_Sanders@dell.com>
Date:   Thu Feb 9 13:51:13 2023 -0500

    Feb 9 Meeting Notes and Recording

    Signed-off-by: Mark Sanders <Mark_S_Sanders@dell.com>

commit e47b78c4d273fb108a16a7b406334e3dbcb43da6
Author: Vipin Jain <jainvipin@gmail.com>
Date:   Wed Feb 8 23:43:30 2023 -0800

    fix linting in opinetcommon

    Signed-off-by: Vipin Jain <jainvipin@gmail.com>

commit 751ab9b6c1e72a16e22726d3cb55f0b7fef84cb3
Author: Mark Sanders <Mark_S_Sanders@dell.com>
Date:   Thu Feb 2 14:06:00 2023 -0500

    Meeting Minutes and Folder Re-ordering

    Signed-off-by: Mark Sanders <Mark_S_Sanders@dell.com>

commit 587807893c5eb20693459149d85ded3fb3a2b56b
Author: Mark Sanders <Mark_S_Sanders@dell.com>
Date:   Thu Feb 2 14:06:00 2023 -0500

    Meeting Minutes and Folder Re-ordering

    Signed-off-by: Mark Sanders <Mark_S_Sanders@dell.com>

commit 786c8c2f2650261cde0381593b65b3f637c41094
Author: Vipin Jain <jainvipin@gmail.com>
Date:   Thu Feb 2 10:19:44 2023 -0800

    add autogenerated apis

    Signed-off-by: Vipin Jain <jainvipin@gmail.com>

commit af4e4458f75c18ed33287f7d33d1239ec53019df
Author: Vipin Jain <jainvipin@gmail.com>
Date:   Thu Jan 26 12:33:17 2023 -0800

    incorporate fourth round of feedback

    Signed-off-by: Vipin Jain <jainvipin@gmail.com>

commit d966a6eff77e9c44d60af126eee9ff690519fd96
Author: Vipin Jain <jainvipin@gmail.com>
Date:   Fri Jan 20 13:45:01 2023 -0800

    incorporate third round of feedback

    Signed-off-by: Vipin Jain <jainvipin@gmail.com>

commit 0a19adb4f5924dc9cfa6326ddd0490002d7ee292
Author: Vipin Jain <jainvipin@gmail.com>
Date:   Thu Jan 19 16:56:13 2023 -0800

    incorporate second round of feedback

    Signed-off-by: Vipin Jain <jainvipin@gmail.com>

commit 8d3baa5d4bfa39b77b50550559c5e61c1cbe1203
Author: Vipin Jain <jainvipin@gmail.com>
Date:   Wed Jan 18 21:23:07 2023 -0800

    incorporate first round of feedback

    Signed-off-by: Vipin Jain <jainvipin@gmail.com>

commit 1f0fa1f2d44f96130956d2c26f49695a22deb272
Author: Vipin Jain <jainvipin@gmail.com>
Date:   Wed Jan 18 01:46:59 2023 -0800

    fix md linters

    Signed-off-by: Vipin Jain <jainvipin@gmail.com>

commit 8839efd28f2ebd45bd26d9590650626d6cf00b25
Author: Vipin Jain <jainvipin@gmail.com>
Date:   Wed Jan 18 01:20:19 2023 -0800

    first revision - cloud protos

    Signed-off-by: Vipin Jain <jainvipin@gmail.com>

commit 507ed8df857cef13f42d9204a647cdb8ae7bc7ff
Author: Mark Sanders <Mark_S_Sanders@dell.com>
Date:   Wed Feb 1 17:00:40 2023 -0500

    K8s CNI doc contribution

    Signed-off-by: Mark Sanders <Mark_S_Sanders@dell.com>

commit acc1537d34a643d36c27e33c502e36db5b42aabd
Author: Mark Sanders <Mark_S_Sanders@dell.com>
Date:   Tue Jan 31 13:16:52 2023 -0500

    Networking Cloud Models and K8s Scenario Docs

    Signed-off-by: Mark Sanders <Mark_S_Sanders@dell.com>

commit 72c8c2c739940132a18254be93095cf5ea7b3192
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Tue Jan 31 16:35:52 2023 +0000

    Update docker/setup-buildx-action digest to 11e8a2e

commit fa7544bab96018aa73ec17b4999fca53e6759e01
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Mon Jan 30 14:25:52 2023 +0000

    Update docker/setup-buildx-action digest to 15c905b

commit df8f9e8fa6e267032fdad81953a48cebdf68b8ac
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Sat Jan 28 15:44:52 2023 +0000

    Update docker/setup-buildx-action digest to 0648fd6

commit 3f4a4c1386bc3b9a20f3b7097e0547e8bf709f9b
Author: Mark Sanders <Mark_S_Sanders@dell.com>
Date:   Thu Jan 26 14:39:32 2023 -0500

    Update Meeting Minutes

    Signed-off-by: Mark Sanders <Mark_S_Sanders@dell.com>

commit 1e771510c99635b1d1046674cbd9a6a65d7e0811
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Wed Jan 25 15:28:32 2023 +0000

    Update docker/setup-buildx-action digest to 7932f62

commit 10e47bafd42bb8a656c7071b94794674c6f95d61
Author: Narayana Prasad <110230547+pathreya@users.noreply.github.com>
Date:   Tue Jan 17 16:49:12 2023 +0530

    Update VNIC+NVME usecase with NVMe + TCP(Local Host) + Tunnel cases

    Signed-off-by: Narayana Prasad <110230547+pathreya@users.noreply.github.com>

commit 70c6bb601b830963652ddb215985ea7802a14909
Author: Mark Sanders <Mark_S_Sanders@dell.com>
Date:   Fri Jan 20 13:09:47 2023 -0500

    Cleanup Meeting Minutes and add Topics and Recording information

    Signed-off-by: Mark Sanders <Mark_S_Sanders@dell.com>

commit c5a05169f40d76d08f20db9d1eb9ec6ed1a60fe8
Author: Mark Sanders <Mark_S_Sanders@dell.com>
Date:   Fri Jan 20 13:09:47 2023 -0500

    Cleanup Meeting Minutes and add Topics and Recording information

    Signed-off-by: Mark Sanders <Mark_S_Sanders@dell.com>

commit e4b3480e8ee92ca5cb7e5756ece9d90c58d2bf76
Author: Boris Glimcher <Boris.Glimcher@emc.com>
Date:   Wed Jan 11 02:06:13 2023 +0200

    [storage] auto-generate protos

    Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>

commit 2cb20c0709c94a2bd6fc3641c11e7c359fb15ca8
Author: Boris Glimcher <Boris.Glimcher@emc.com>
Date:   Wed Jan 11 02:01:42 2023 +0200

    [inventory] Add documentation

    Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>

commit 18c8c629ed6f32ac8e4d4034f401dda620a03849
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Sun Jan 8 17:57:49 2023 +0000

    Update docker/setup-buildx-action digest to 165fe68

commit 758ba819a8f96c4235f339c1b391536aac67bfaf
Author: Boris Glimcher <Boris.Glimcher@emc.com>
Date:   Thu Jan 5 22:10:33 2023 +0200

    [network] move old APIs

    Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>

commit 004be1393a93b62e8a5818690d0b9b8031e43032
Author: Boris Glimcher <Boris.Glimcher@emc.com>
Date:   Thu Jan 5 21:48:22 2023 +0200

    [network] auto-generate protos

    Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>

commit f410dd41888561568e9a9c726b145b305d432231
Author: Boris Glimcher <Boris.Glimcher@emc.com>
Date:   Thu Jan 5 21:54:24 2023 +0200

    add readme

    Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>

commit cae11516dc1f1c748a1faa085087e2d8282847f3
Author: Boris Glimcher <Boris.Glimcher@emc.com>
Date:   Thu Jan 5 21:35:53 2023 +0200

    CI: add globbing to ignore

    Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>

commit ba9e88ed9a4877a0e3ec9612609dd262354bb2a3
Author: Boris Glimcher <Boris.Glimcher@emc.com>
Date:   Thu Jan 5 21:02:31 2023 +0200

    net: Add opinetcommon folder

    Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>

commit c54f03d33dc1a5d868b8e86f001240cea0eecb12
Author: Boris Glimcher <Boris.Glimcher@emc.com>
Date:   Thu Jan 5 20:50:14 2023 +0200

    Networking: add folders for cloud, k8s and telco

    Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>

commit 844775ae0e145f5149addf9a8fb07e5f4c1d9225
Author: Boris Glimcher <Boris.Glimcher@emc.com>
Date:   Tue Dec 20 02:38:55 2022 +0200

    Inventory: add system

    Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>

commit 36b74237699115263f9ca8e6d5719ffb96cf52d8
Author: Boris Glimcher <Boris.Glimcher@emc.com>
Date:   Tue Dec 20 02:24:44 2022 +0200

    Add network badge

    Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>

commit dfcd394c45c0c84fe272de42c43fde73c1dbf5a6
Author: Boris Glimcher <Boris.Glimcher@emc.com>
Date:   Tue Dec 20 02:23:15 2022 +0200

    Auto-gen docs

    Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>

commit cfa9a4cb3bf393a343ff2cd69acd7e13604ff5b7
Author: Boris Glimcher <Boris.Glimcher@emc.com>
Date:   Tue Dec 20 02:22:09 2022 +0200

    Fix CI

    Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>

commit bc45d248e331da313ee4695d19a67031e4a8abc6
Author: Boris Glimcher <Boris.Glimcher@emc.com>
Date:   Tue Dec 20 01:52:44 2022 +0200

    Inventory: add bios,baseboard,chassis,processor,memory

    Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>

commit 985e235ebcda1112c36f00bccfd9349eca90f971
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Mon Dec 19 23:07:58 2022 +0000

    Update docker/setup-buildx-action digest to c252a3b

commit 904f6730e136143dcc1fbe94c983a71a574a4607
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Mon Dec 19 19:39:43 2022 +0000

    Update docker/setup-buildx-action digest to 22f6533

commit ab4bf01d6bfb9c9ea8abf48848e9227ccb16b8fc
Author: Vipin Jain <jainvipin@gmail.com>
Date:   Fri Dec 16 16:55:43 2022 -0800

    fix language

    Signed-off-by: Vipin Jain <jainvipin@gmail.com>

commit 1b6375b6517dc951962cf44b9ac821bbf4a3dbc4
Author: Vipin Jain <jainvipin@gmail.com>
Date:   Fri Dec 16 14:14:43 2022 -0800

    vendor extensions - follow up feedback from PR 224

    Signed-off-by: Vipin Jain <jainvipin@gmail.com>

commit 6078c7e2edf66197d6adbfa939ded4a881b77bcc
Author: Boris Glimcher <Boris.Glimcher@emc.com>
Date:   Fri Dec 16 15:49:45 2022 +0200

    Add empty ip.proto and enable linters

    Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>

commit 35ca016f207467dd6fb396897b786520052566cf
Author: Vipin Jain <jainvipin@gmail.com>
Date:   Thu Dec 15 08:46:40 2022 -0800

    vendor extensions - incorporate feedback

    Signed-off-by: Vipin Jain <jainvipin@gmail.com>

commit 43a1e1ecc712b636199de014c27d2d417117ed95
Author: Vipin Jain <jainvipin@gmail.com>
Date:   Wed Dec 14 14:23:49 2022 -0800

    vendor extensions - incorporate feedback

    Signed-off-by: Vipin Jain <jainvipin@gmail.com>

commit 72cd215476f0a6d9aefe4dc0e3d9b8ac8d803599
Author: Vipin Jain <jainvipin@gmail.com>
Date:   Mon Dec 12 17:51:10 2022 -0800

    document api extension methods

    Signed-off-by: Vipin Jain <jainvipin@gmail.com>

commit a49a4ea1d561c7bfa045c2d04141526eebd8239c
Author: Mark Sanders <marksanders194@gmail.com>
Date:   Mon Dec 12 20:26:05 2022 +0000

    Add inventory protobuf

    Signed-off-by: Mark Sanders <marksanders194@gmail.com>

commit 216c01770353f0f51ef5c603cd2d44f7226213cc
Author: Mark Sanders <marksanders194@gmail.com>
Date:   Mon Dec 12 20:26:05 2022 +0000

    Add inventory protobuf

    Signed-off-by: Mark Sanders <marksanders194@gmail.com>

commit b9358a2a96f8c961175df3e5df67df5f038a58b8
Author: Dan Daly <dan.daly@intel.com>
Date:   Tue Dec 13 13:32:11 2022 -0800

    IPDK Storage APIs set to 80 chars

    Signed-off-by: Dan Daly <dan.daly@intel.com>

commit cf94dd9136ab8615f7b89307da76fcde4dfbe896
Author: Dan Daly <dan.daly@intel.com>
Date:   Tue Dec 13 11:14:50 2022 -0800

    IPDK Storage APIs

    Signed-off-by: Dan Daly <dan.daly@intel.com>

commit 4ab228a467f761a3f012a567659b94e9b215d17b
Author: Boris Glimcher <Boris.Glimcher@emc.com>
Date:   Tue Dec 13 00:36:17 2022 +0200

    Add comon java generation

    Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>

commit b1b2672e72be1953190c2f583c53ec2f05c04534
Author: Boris Glimcher <Boris.Glimcher@emc.com>
Date:   Fri Dec 9 17:50:24 2022 +0200

    [storage] define statistics object

    Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>

commit 65d9273044716149a50904f88dcda8c927977d2f
Author: Boris Glimcher <Boris.Glimcher@emc.com>
Date:   Thu Dec 8 22:52:43 2022 +0200

    [storage] auto-generate protos

    Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>

commit 3cb34044c1af59098b0f509982ad1ffa91e5bdec
Author: Boris Glimcher <Boris.Glimcher@emc.com>
Date:   Thu Dec 8 21:36:00 2022 +0200

    fix google.api.resource_reference

    Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>

commit b089acb781cd6ccf304bd5d075e150a482a7e3fc
Author: Boris Glimcher <Boris.Glimcher@emc.com>
Date:   Thu Dec 8 18:14:12 2022 +0200

    [storage] auto-generate protos

    Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>

commit 3bea5036ea7f23689abd9a340aade76238b17bc0
Author: Boris Glimcher <Boris.Glimcher@emc.com>
Date:   Thu Dec 8 18:09:27 2022 +0200

    [storage] [lint] Re-enable rule=core::0133

    Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>

commit 895f155ff8499ac9d27aed339028ebca8d4e891d
Author: Boris Glimcher <Boris.Glimcher@emc.com>
Date:   Thu Dec 8 17:37:41 2022 +0200

    [storage] [lint] Re-enable rule=core::0134

    Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>

commit 9d0e03020e8276eb1e6c564f3291d79ba4ce109b
Author: Boris Glimcher <Boris.Glimcher@emc.com>
Date:   Thu Dec 8 16:58:19 2022 +0200

    [storage] [lint] Re-enable rule=core::0132

    Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>

commit fa9f7801512639889905b4600b731a236f672969
Author: Boris Glimcher <Boris.Glimcher@emc.com>
Date:   Thu Dec 8 03:43:02 2022 +0200

    [storage] [lint] Re-enable rule=core::0131

    Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>

commit 1410d1941a862bae13af388c387f6b1448ef2f01
Author: Boris Glimcher <Boris.Glimcher@emc.com>
Date:   Thu Dec 8 03:35:36 2022 +0200

    [storage] [lint] Re-enable rule=core::0135

    Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>

commit fd93b840b575f4853eb9c79ff7a0435404adaf38
Author: Boris Glimcher <Boris.Glimcher@emc.com>
Date:   Tue Dec 6 22:03:49 2022 +0200

    [storage] [backend] AIP Get/List/Create/Update/Delete rename

    See #174

    Resource-oriented design https://google.aip.dev/121

    for word in Get List Create Update Delete; do
      for i in AioController NullDebug NVMfRemoteController; do
        sed -i "s/${i}${word}/${word}${i}/g" v1alpha1/backend_*.proto ;
      done;
    done

    Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>

commit 5d56f220233591bfc59b6457ae65b2ebe742ff25
Author: Boris Glimcher <Boris.Glimcher@emc.com>
Date:   Tue Dec 6 17:56:43 2022 +0200

    [storage] [backend] Add Handle to BE object now

    Related to #174

    Resource-oriented design https://google.aip.dev/121

    Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>

commit b10361a9c1190b6393387548f2ccbcb14c4191b3
Author: Boris Glimcher <Boris.Glimcher@emc.com>
Date:   Tue Nov 29 01:09:50 2022 +0200

    Add Hostnqn to backend

    Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>

commit 5d2289de810a8b6464e3ff54daeaa6596975f703
Author: Vipin Jain <jainvipin@gmail.com>
Date:   Mon Nov 21 11:26:56 2022 -0800

    change crypto to EncryptedVolume #210

    Signed-off-by: Vipin Jain <jainvipin@gmail.com>

commit ca2c25b808b32b217e946ec3145863f1e8814f03
Author: Ben Walker <benjamin.walker@intel.com>
Date:   Mon Nov 14 12:28:33 2022 -0700

    [storage] Remove NVMe parameters from front-end that don't belong

    Many of these will end up on the middle/back-end instead.

    Signed-off-by: Ben Walker <benjamin.walker@intel.com>

commit ffe4aadd66cabba3f472c785594330e76fd92de4
Author: Boris Glimcher <Boris.Glimcher@emc.com>
Date:   Wed Nov 16 00:37:37 2022 +0200

    [storage] rename volume_id to crypto_id

    Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>

commit 8a4c97fceb0679c02e6f43caaf5a642bb13bf04c
Author: Boris Glimcher <Boris.Glimcher@emc.com>
Date:   Mon Nov 14 22:37:24 2022 +0200

    [storage] Add Crypto middle end volume

    Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>

commit 23fcac6de23047c105ab477f7672f9ee3179105e
Author: Ben Walker <benjamin.walker@intel.com>
Date:   Mon Nov 14 12:41:18 2022 -0700

    [storage] Add target to virtio-scsi, clean up virtio-blk

    Signed-off-by: Ben Walker <benjamin.walker@intel.com>

commit b94e8f8801240c7a66e644a708a10a3386c5e628
Author: Boris Glimcher <Boris.Glimcher@emc.com>
Date:   Mon Nov 14 18:11:31 2022 +0200

    [storage] auto-generate protos

    Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>

commit fe7c388c148d3d7ce4edd3661be9c30bc9f399ef
Author: Boris Glimcher <Boris.Glimcher@emc.com>
Date:   Mon Nov 14 18:07:16 2022 +0200

    Fixing namespace conflict

    common is too generic and we hit namespace conflict
    when we try to use it.

    see https://stackoverflow.com/questions/67693170/proto-file-is-already-registered-with-different-packages
    see https://developers.google.com/protocol-buffers/docs/reference/go/faq#fix-namespace-conflict

    Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>

commit 34e208409ec28e95d06fc4408cdb50c875fa49c2
Author: Boris Glimcher <Boris.Glimcher@emc.com>
Date:   Fri Nov 11 21:28:03 2022 +0200

    [storage] [lint] Re-enable rule=core::0158

    Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>

commit 12de4dd988a06a368b2ec8459f82ac94357f50ee
Author: Boris Glimcher <Boris.Glimcher@emc.com>
Date:   Thu Nov 10 22:28:19 2022 +0200

    [storage] auto-generate protos

    Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>

commit 28dd2190a35dbcbefe550b0ba569f21b38e8909d
Author: Boris Glimcher <Boris.Glimcher@emc.com>
Date:   Thu Nov 10 21:44:06 2022 +0200

    [storage] [frontend] AIP Get/List/Create/Update/Delete rename

    See #174

    Resource-oriented design https://google.aip.dev/121

    for word in Get List Create Update Delete; do
      for i in NVMeSubsystem NVMeController NVMeNamespace VirtioBlk VirtioScsiController VirtioScsiLun; do
        sed -i "s/${i}${word}/${word}${i}/g" v1alpha1/frontend_*.proto ;
      done;
    done

    Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>

commit 70e9b94f06393644c187704fd5e64cbdba68165e
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Thu Nov 10 18:16:17 2022 +0000

    chore(deps): update docker/setup-buildx-action digest to 39a1a82

commit ff3fb4ac5d061f72383a8efdeaaac95fb3ef75cc
Author: Boris Glimcher <Boris.Glimcher@emc.com>
Date:   Thu Nov 10 15:27:14 2022 +0200

    [storage] [backend] Add Handle to BE object now

    Related to #174

    Resource-oriented design https://google.aip.dev/121

    Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>

commit 28e180c2b8619675377a359cac0bcb05b2c4761e
Author: Vipin Jain <jainvipin@gmail.com>
Date:   Wed Nov 9 13:14:19 2022 -0800

    Separate Spec (user configuration) and Status (system state) fields

    Signed-off-by: Vipin Jain <jainvipin@gmail.com>

commit 124cf8307f4101eeafb707a8ec64fbf96eb80e3c
Author: Ben Walker <benjamin.walker@intel.com>
Date:   Wed Nov 9 11:57:01 2022 -0700

    storage: Update generated output after PciEndpoint change

    Signed-off-by: Ben Walker <benjamin.walker@intel.com>

commit bda598925e9706ef4ecc93e8ab1112adf0992159
Author: Ben Walker <benjamin.walker@intel.com>
Date:   Thu Oct 27 10:49:07 2022 -0700

    [storage] Rename NvmeControllerPciId to PciEndpoint

    This is an important change. The OPI configuration APIs cannot pick the
    bus:device:function - that's assigned by the OS PCI driver. We can only
    pick the physical and virtual function numbers.

    Signed-off-by: Ben Walker <benjamin.walker@intel.com>

commit 1fdb13d9f4f26661acb18ea8d05dc74ca2033b4d
Author: Boris Glimcher <Boris.Glimcher@emc.com>
Date:   Wed Nov 9 17:31:29 2022 +0200

    [storage] auto-generate protos

    Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>

commit e420f8cdd9cc0f2637f0aedb78e4d540b00d9f06
Author: Boris Glimcher <Boris.Glimcher@emc.com>
Date:   Wed Nov 9 17:30:44 2022 +0200

    [storage] Fix objectIDs in Virtio

    Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>

commit 76522ac45e8980080d2d0dd40e3f72af59cf59fe
Author: Boris Glimcher <Boris.Glimcher@emc.com>
Date:   Wed Nov 9 03:24:29 2022 +0200

    [storage] [lint] Enforcing lint errors on backend

    Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>

commit ae645e3bc8bc5e4fef96ad7dc3963baa5e26de15
Author: Boris Glimcher <Boris.Glimcher@emc.com>
Date:   Wed Nov 9 01:50:13 2022 +0200

    [storage] [lint] Start enforcing lint errors

    name, count, comments, ... see #195

    Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>

commit 8bc7b1116f8aea12e9b914c864790cbf58fa4abf
Author: Boris Glimcher <Boris.Glimcher@emc.com>
Date:   Tue Nov 8 03:43:55 2022 +0200

    [storage] [make] don;t copy files, map folders

    Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>

commit 2a9284753fa3a66ce9a58271b98616aaea2aab5e
Author: Boris Glimcher <Boris.Glimcher@emc.com>
Date:   Tue Nov 8 17:50:15 2022 +0200

    [storage] auto-generate protos

    Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>

commit 0e0f996149ba70add337ff2048afc6a21dab1cbd
Author: Boris Glimcher <Boris.Glimcher@emc.com>
Date:   Tue Nov 8 17:48:16 2022 +0200

    Fixing linters #195

    Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>

commit 50dd35e8bdf94f5cd0e810f8a17ef3bff2d59849
Author: Boris Glimcher <Boris.Glimcher@emc.com>
Date:   Tue Nov 8 04:23:13 2022 +0200

    [storage] Add java support

    Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>

commit 72b6da21c09a085e979e94ee4ac8346da10d962b
Author: Boris Glimcher <Boris.Glimcher@emc.com>
Date:   Tue Nov 8 03:20:53 2022 +0200

    [storage] auto-generate protos

    Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>

commit 781942f2537c19a484128dfd0189e334b781d0d8
Author: Boris Glimcher <Boris.Glimcher@emc.com>
Date:   Tue Nov 8 01:21:25 2022 +0200

    [storage] move v1 to v1alpha1

    Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>

commit 363b2ecc99ebd0ef07b97374a9c37b6d716bdd0f
Author: Boris Glimcher <Boris.Glimcher@emc.com>
Date:   Thu Nov 3 22:16:02 2022 +0200

    [storage] auto-generate protos

    Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>

commit 8dcceff288fe07cf6507d0e95a5e64290ec9c439
Author: Boris Glimcher <Boris.Glimcher@emc.com>
Date:   Thu Nov 3 22:15:23 2022 +0200

    [storage][front-end] Unify Subsystem, Controller, Namespace in a single service

    Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>

commit bb436edcc035cd2df77f024a75270e7aadfbe03f
Author: Boris Glimcher <Boris.Glimcher@emc.com>
Date:   Thu Nov 3 21:21:44 2022 +0200

    [storage] auto-generate protos

    Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>

commit fd4d33ac9d9c41450ed916c52adb7b893e519e44
Author: Boris Glimcher <Boris.Glimcher@emc.com>
Date:   Wed Nov 2 23:36:17 2022 +0200

    [storage][front-end] Add google.api.http

    Following Google AIP-127 - HTTP and gRPC Transcoding

    Related to #174

    Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>

commit 4c2c4f473950021c22455c5bc75dd4eb60febe7c
Author: Boris Glimcher <Boris.Glimcher@emc.com>
Date:   Thu Nov 3 17:25:38 2022 +0200

    [storage] add missing google proto files

    See https://grpc-ecosystem.github.io/grpc-gateway/docs/tutorials/adding_annotations/#using-protoc

    Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>

commit 0d8816b9043aa5e1227d0909aabe3cca079ef7b6
Merge: 805c63e e5a06eb
Author: Mark Sanders <99361819+sandersms@users.noreply.github.com>
Date:   Thu Nov 3 11:08:02 2022 -0400

    Merge pull request #184 from pathreya/preview

    Add VNIC and NVME combined Offload Usecase

commit 805c63e066111229c8afcc93fa3192a53bb1c8d7
Author: Boris Glimcher <Boris.Glimcher@emc.com>
Date:   Wed Nov 2 02:52:53 2022 +0200

    [storage] auto-generate protos

    Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>

commit 381c90327d189364d0adc84062a43373354f4704
Author: Boris Glimcher <Boris.Glimcher@emc.com>
Date:   Wed Nov 2 02:52:33 2022 +0200

    [storage][front-end] Rename crypto_key_id to volume_id

    Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>

commit 3c744e340157c9de54ab9f8ceae8c6ad2bb2c4a9
Author: Boris Glimcher <Boris.Glimcher@emc.com>
Date:   Wed Nov 2 01:38:32 2022 +0200

    [storage] auto-generate protos

    Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>

commit 12796e5924d6f72e2115212e18cb92ce8d7e68c9
Author: Boris Glimcher <Boris.Glimcher@emc.com>
Date:   Wed Nov 2 01:35:18 2022 +0200

    [storage][front-end] Remove xxxGetResponse messages

    Following Google AIP-131 - Standard methods: Get

    Related to #174

    Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>

commit 916e0e05a8edbb347b52a6956dd177f57f75ef96
Author: Boris Glimcher <Boris.Glimcher@emc.com>
Date:   Wed Nov 2 01:32:17 2022 +0200

    [storage][front-end] Remove xxxUpdateResponse messages

    Following Google AIP-134 - Standard methods: Update

    Related to #174

    Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>

commit e5a06ebc78e047485ce2a2695a31e3d7bc5bf0d6
Author: Narayana Prasad <110230547+pathreya@users.noreply.github.com>
Date:   Wed Nov 2 23:52:40 2022 +0530

    Add VNIC and NVME combined Offload Usecase

    Signed-off-by: Narayana Prasad <110230547+pathreya@users.noreply.github.com>

commit 01728cfb4cadbfe3681bc3c6ac031e7b2b5683a2
Author: Narayana Prasad <110230547+pathreya@users.noreply.github.com>
Date:   Wed Nov 2 23:52:40 2022 +0530

    Add VNIC and NVME combined Offload Usecase

    Signed-off-by: Narayana Prasad <110230547+pathreya@users.noreply.github.com>

commit 1b5a67ca57ab726641ba92592b2f1103ca1843de
Author: Boris Glimcher <Boris.Glimcher@emc.com>
Date:   Mon Oct 31 20:48:09 2022 +0200

    [storage] auto-generate protos

    Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>

commit 03947d2ed33fbc69890c3324f13c3da5bcbb9a23
Author: Boris Glimcher <Boris.Glimcher@emc.com>
Date:   Mon Oct 31 20:47:06 2022 +0200

    [storage][front-end] Remove xxxDeleteResponse messages

    Following Google AIP-135 - Standard methods: Delete

    Related to #174

    Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>

commit 22b77cdc06258840f9496b4f61deb6faccdbafc3
Author: Boris Glimcher <Boris.Glimcher@emc.com>
Date:   Mon Oct 31 20:37:08 2022 +0200

    [storage] auto-generate protos

    Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>

commit 9ed7ac23e579cd4c85d93c882a563e44f034fe1c
Author: Boris Glimcher <Boris.Glimcher@emc.com>
Date:   Mon Oct 31 20:34:05 2022 +0200

    [storage][]front-end] Delete xxxCreateResponse messages

    Following Google AIP-133 - Standard methods: Create

    Related to #174

    Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>

commit 5ec9cbc6010918e5651b39d0dc9840f654cdecc6
Author: Amar Vishwakarma <amarv@marvell.com>
Date:   Fri Oct 28 04:27:35 2022 -0400

    Split CQ/SQ and add max queue entries

    1) As per spec multiple submission queues may utilize the same completion queue.
       Hence decoupling the two.
    2) Submission queues and completion queues can have different depths.
    Will push poc updates once poc changes for Vipin's request are uploaded.

    Signed-off-by: Amar Vishwakarma <amarv@marvell.com>
    Signed-off-by: Michal Kalderon <mkalderon@marvell.com>

commit c9df395a897f71b682751059e0ae81bc2bec75cf
Author: Vipin Jain <jainvipin@gmail.com>
Date:   Mon Oct 24 19:29:29 2022 -0700

    remove bdev from namespace, also fix controller_id field in response message

    Signed-off-by: Vipin Jain <jainvipin@gmail.com>

commit caef9b39742694c99af883ca4a4ab7655dd89660
Author: Vipin Jain <jainvipin@gmail.com>
Date:   Mon Oct 24 13:53:26 2022 -0700

    remove NvmePathMgmtType and NvmeFrontEndConstants; also change the keys in request/response messages

    Signed-off-by: Vipin Jain <jainvipin@gmail.com>

commit f831646e45375dd9e408055de7d566725f6ceb77
Author: Vipin Jain <jainvipin@gmail.com>
Date:   Fri Oct 21 12:58:29 2022 -0700

    remove multipath and authentication fields from namespace object

    Signed-off-by: Vipin Jain <jainvipin@gmail.com>

commit 0e105212ccbf5e3da00cf6df2e919923f530d9ad
Author: Vipin Jain <jainvipin@gmail.com>
Date:   Fri Oct 21 12:15:08 2022 -0700

    remove name from controller and namespace objects

    Signed-off-by: Vipin Jain <jainvipin@gmail.com>

commit 50998145384c87210caf0b8b50026fef3e3c0365
Author: Vipin Jain <jainvipin@gmail.com>
Date:   Fri Oct 21 11:25:15 2022 -0700

    use object key vs uuid to identify an object

    Signed-off-by: Vipin Jain <jainvipin@gmail.com>

commit 93cd086195d513aeceb677dac66b5d07a19e3ef1
Author: Vipin Jain <jainvipin@gmail.com>
Date:   Fri Oct 21 00:35:59 2022 -0700

    frontend proto changes

    Signed-off-by: Vipin Jain <jainvipin@gmail.com>

commit 8703af0d8989ea63da95f46cf76711ea6210d180
Author: Boris Glimcher <Boris.Glimcher@emc.com>
Date:   Tue Oct 18 23:16:26 2022 +0300

    storage: fix empty reponse in VirtioBlkListResponse

    Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>

commit d2a93c1bd40b39bd26941554210f271649b10d7d
Author: Boris Glimcher <Boris.Glimcher@emc.com>
Date:   Tue Oct 18 14:13:33 2022 +0300

    ci: fail if forget to auto-generate protos

    Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>

commit 1eaf24be7a73698d2224544f40b3a6ac86ee299b
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Tue Oct 18 10:51:37 2022 +0000

    chore(deps): update docker/setup-buildx-action digest to 8c0edbc

commit c7e517faa5a0e350a360f5ca68637c84b4a2140d
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Mon Oct 17 15:48:56 2022 +0000

    chore(deps): update docker/setup-buildx-action digest to c74574e

commit 8bca3c0ece2b3d751d49604025e1a46b4e5d4af0
Author: PWAlessi <pwalessi1@gmail.com>
Date:   Mon Oct 17 11:51:50 2022 -0400

    Generate new storage artifacts

    Signed-off-by: PWAlessi <pwalessi1@gmail.com>

commit 35deb3bd00d959459597b4a156239ae4bb2684cc
Author: PWAlessi <pwalessi1@gmail.com>
Date:   Mon Oct 17 11:30:05 2022 -0400

    Remove int64 id field from AioController message

    Signed-off-by: PWAlessi <pwalessi1@gmail.com>

commit 3b867a7610e90832f150a0d262a82897d32ee318
Author: PWAlessi <pwalessi1@gmail.com>
Date:   Mon Oct 17 11:25:43 2022 -0400

    Remove AioControllerGetByName rpc and Requst object

    Signed-off-by: PWAlessi <pwalessi1@gmail.com>

commit 0f50a6274fcac8b28d6986ffa8c306bd68e92f6c
Author: PWAlessi <pwalessi1@gmail.com>
Date:   Mon Oct 17 10:00:50 2022 -0400

     Added AioControllerGetByName to allow retrieval of Aio Controller by
    name

    Signed-off-by: PWAlessi <pwalessi1@gmail.com>

commit 69b132c4e5d3169c28ddd841330ad738101b8de7
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Fri Oct 14 19:17:29 2022 +0000

    chore(deps): update docker/setup-buildx-action digest to 59b5ed6

commit 65199a33c618c6563611937f3dc82f817a2d9703
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Wed Oct 12 13:41:39 2022 +0000

    chore(deps): update docker/setup-buildx-action digest to 95cb08c

commit 818456185664e027fffe96fa8bbf4cb1ae3b36a7
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Mon Oct 10 12:54:00 2022 +0000

    chore(deps): add renovate.json

commit 71dfd92661fb7ce966d2051aa6d819b8a7a9d0b3
Author: Kyle Mestery <mestery@mestery.com>
Date:   Tue Oct 11 14:14:31 2022 -0500

    firewall: Remove last trace

    Commit b33fa3b removed the firewall code, but this last reference was
    left dangling. This commit removes that.

    Signed-off-by: Kyle Mestery <mestery@mestery.com>

commit b33fa3b037e3e70677c78889cbe48960bee83633
Author: Kyle Mestery <mestery@mestery.com>
Date:   Tue Oct 11 13:58:23 2022 -0500

    firewall: Remove firewall API

    We have forked the sessionoffload API here [1] and are iterating on it
    there. We should remove it from the opi-api repository at this point.

    [1] https://github.com/opiproject/sessionOffload

    Signed-off-by: Kyle Mestery <mestery@mestery.com>

commit 9bc861df674d68d9b562e2213a820f9b39722f55
Author: PWAlessi <pwalessi1@gmail.com>
Date:   Tue Oct 11 14:47:01 2022 -0400

    remove the word Remote since AIO always works on local devices

    Signed-off-by: PWAlessi <pwalessi1@gmail.com>

commit 8bff68687f9f0c7bf6d5243e004e93770da28a2c
Author: PWAlessi <pwalessi1@gmail.com>
Date:   Tue Oct 11 14:35:06 2022 -0400

    Add backend_aio proto

    Signed-off-by: PWAlessi <pwalessi1@gmail.com>

commit c65f60c84188b274fb702c2887adb95345b70fef
Author: PWAlessi <pwalessi1@gmail.com>
Date:   Tue Oct 11 12:11:35 2022 -0400

    Correct go_package path

    Signed-off-by: PWAlessi <pwalessi1@gmail.com>

commit d92cc35244e7753f701740198c55416336d32d0e
Author: Boris Glimcher <Boris.Glimcher@emc.com>
Date:   Mon Oct 10 23:33:18 2022 +0300

    proto: add --rm and --user to makefiles

    Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>

commit 2acfad196d851d2df7107da5b8ce78b4fed7f465
Author: Boris Glimcher <36732377+glimchb@users.noreply.github.com>
Date:   Thu Oct 6 20:35:36 2022 -0400

    Create CODEOWNERS

commit 52dcb60592c8f66544c6bab2c143db097b9dc57e
Author: PWAlessi <pwalessi1@gmail.com>
Date:   Wed Oct 5 15:51:31 2022 -0400

    Generated artifacts

    Signed-off-by: PWAlessi <pwalessi1@gmail.com>

commit 17c331d1d10d9fe5ff6dec6eac673f5c0827e633
Author: PWAlessi <pwalessi1@gmail.com>
Date:   Wed Oct 5 15:50:05 2022 -0400

    Updated comment on ObjectKey type per review comments

    Signed-off-by: PWAlessi <pwalessi1@gmail.com>

commit acf3cd1f954b9a8c69a269c8804f2c0f72f1dc57
Author: PWAlessi <pwalessi1@gmail.com>
Date:   Wed Oct 5 14:44:02 2022 -0400

    Added ObjectKey type

    Signed-off-by: PWAlessi <pwalessi1@gmail.com>

commit b3a7940b9c44cc191034f07fdc01e49951fafeec
Author: Boris Glimcher <Boris.Glimcher@emc.com>
Date:   Wed Oct 5 20:02:44 2022 +0300

    ci: fix actions after folders restructure

    Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>

commit 5b83404bd7f578b76650650e8e262201cd6c45c5
Author: PWAlessi <pwalessi1@gmail.com>
Date:   Wed Oct 5 12:57:52 2022 -0400

    Update linters to ignore common autogen file

    Signed-off-by: PWAlessi <pwalessi1@gmail.com>

commit b93ba2fba2e3e560496a736781cb10a5d1d8a577
Author: PWAlessi <pwalessi1@gmail.com>
Date:   Wed Oct 5 12:29:09 2022 -0400

    Add makefile to build common generated files

    Signed-off-by: PWAlessi <pwalessi1@gmail.com>

commit 7dc93ae180a029ce6d7d2e51142c5b912a944fad
Author: patrick-alessi <patrick.alessi@dell.com>
Date:   Wed Oct 5 11:00:09 2022 -0400

    Move Uuid message definition up to top level common directory
    because it is used across protos in security and storage

    Signed-off-by: patrick-alessi <patrick.alessi@dell.com>

commit 0ce0fa11f18c78d2f14c08a28ebf37df91e6bf5c
Author: Boris Glimcher <Boris.Glimcher@emc.com>
Date:   Tue Oct 4 15:49:42 2022 +0300

    ci: fix ignore md linter

    Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>

commit 9a508a4baa1911140eb5b1501238c4511a6250de
Author: patrick-alessi <patrick.alessi@dell.com>
Date:   Mon Oct 3 15:21:25 2022 -0400

    Move generated code to /gen directory
    Move code generated for each language into a language specific directory
    Update makefiles with new generated code locations
    Delete old generated code

    Signed-off-by: patrick-alessi <patrick.alessi@dell.com>

commit 681e3e3f1a48f511fe8a25acb7f6f0962e875be9
Author: patrick-alessi <patrick.alessi@dell.com>
Date:   Mon Oct 3 10:29:31 2022 -0400

    Implement File and directory structure per AIP-191
    https://google.aip.dev/191

    Renamed files to use snake_case
    Moved protos into v1 directories
    Updated package declarations to use correct directory path with
    snake_case
    Updated go_package directory locations
    Updated makefiles

    Signed-off-by: patrick-alessi <patrick.alessi@dell.com>

commit e82b272479ccc6d9b8ab71f2b7bb47f802fe3ec6
Author: Boris Glimcher <Boris.Glimcher@emc.com>
Date:   Thu Sep 29 20:29:36 2022 +0300

    revert: need go files for package

    Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>

commit e70307c5a9823fcaaca6b45a9e7747289b2e9abc
Author: Boris Glimcher <Boris.Glimcher@emc.com>
Date:   Thu Sep 29 19:14:42 2022 +0300

    storage: add NULL to proto for debug

    Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>

commit 95b2b4b0105feb1016833331297520e29fbb0438
Author: Boris Glimcher <Boris.Glimcher@emc.com>
Date:   Thu Sep 29 18:20:58 2022 +0300

    proto: add python and cpp

    Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>

commit 5c7839cd89991b7cf82dae49450fd15645aa6e5d
Author: Boris Glimcher <Boris.Glimcher@emc.com>
Date:   Thu Sep 29 18:19:22 2022 +0300

    remove auto-gen files

    Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>

commit 2c9c3cd8f4fcf2730cc9a714bdc0f1443be6b99e
Author: Boris Glimcher <Boris.Glimcher@emc.com>
Date:   Thu Sep 29 16:52:25 2022 +0300

    ci: fix api linter

    Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>

commit 621989d137799b6429d174683dc6fb939ecce592
Author: Boris Glimcher <Boris.Glimcher@emc.com>
Date:   Thu Sep 29 01:55:31 2022 +0300

    make: add api-linter

    Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>

commit 83095bd0dea3843588fae659fa351565a7b26268
Author: Boris Glimcher <Boris.Glimcher@emc.com>
Date:   Wed Sep 28 22:48:21 2022 +0300

    unify linters to match other repos we have

    Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>

commit ce05b0145ff4b51c09e03bf354b51f8d734fb51c
Author: patrick-alessi <patrick.alessi@dell.com>
Date:   Wed Sep 28 15:30:14 2022 -0400

    Add aip linter action
    Action does not fail build, it just outputs results

    Signed-off-by: patrick-alessi <patrick.alessi@dell.com>

commit 871ea63d879afbb846300c0f616b16ed4416090e
Author: Boris Glimcher <Boris.Glimcher@emc.com>
Date:   Wed Sep 28 21:11:59 2022 +0300

    storage: add NvmeControllerPciId

    Baed on #133 contribution

    Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>

commit 8889179a8711f5a7166df6bb10989d5002683d36
Author: Boris Glimcher <Boris.Glimcher@emc.com>
Date:   Wed Sep 28 21:17:11 2022 +0300

    storage: add Copyright

    Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>

commit ea226ae1b7052e896d89b39b54dd541a7497e09e
Author: Michal Kalderon <mkalderon@marvell.com>
Date:   Thu Sep 22 16:15:10 2022 +0300

    Storage: Update CSI related images

    Change terminology. Change Master nodes with Management nodes,
    to avoid harmful language.

    Also added missing arrow in option #2

    Signed-off-by: Michal Kalderon <mkalderon@marvell.com>

commit 7db2a1b66f085b1c8802da0c864e0b3159c697ae
Author: Kyle Mestery <mestery@mestery.com>
Date:   Wed Sep 21 14:11:29 2022 -0500

    session: Change session ID to UUID

    Instead of using a uin64, move Session ID to a UUID, which is much
    better practice.

    Signed-off-by: Kyle Mestery <mestery@mestery.com>

commit 913520c45d4eeb86c845527db17379159c351608
Author: Kyle Mestery <mestery@mestery.com>
Date:   Wed Sep 21 12:40:50 2022 -0500

    session: Add proxy ActionType

    This adds a new _PROXY ActionType to allow for offloading proxy
    sessions. Should work for both standard TCP and UDP proxies, as well as
    QUIC proxies.

    Signed-off-by: Kyle Mestery <mestery@mestery.com>

commit 1f88e822cc121c1f6874d894956521b57f2beac5
Author: Boris Glimcher <Boris.Glimcher@emc.com>
Date:   Thu Sep 22 15:58:27 2022 +0300

    ci: add network

    Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>

commit 57d6c6f184faaefd9c7d5420199d68df1235ff84
Author: Boris Glimcher <Boris.Glimcher@emc.com>
Date:   Thu Sep 22 00:16:20 2022 +0300

    proto: clean old files before generating new ones

    Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>

commit 9835d42c6d9f4c4b5c16c3eb3d822219bf50775f
Merge: e10810f e566af6
Author: Mark Sanders <99361819+sandersms@users.noreply.github.com>
Date:   Wed Sep 21 17:10:35 2022 -0400

    Merge pull request #125 from sandersms/main

    Networking Interfaces protobuf file

commit e566af66acb4f097c47e66d5737750cd0cc393d1
Merge: 6b77ce4 419e403
Author: Mark Sanders <Mark_S_Sanders@dell.com>
Date:   Wed Sep 21 17:08:55 2022 -0400

    Merge branch 'main' of https://github.com/sandersms/opi-api

commit 6b77ce4e34d94e6929db4ddbba9e63bea385c053
Merge: 781b933 d90acbb
Author: Mark Sanders <Mark_S_Sanders@dell.com>
Date:   Wed Sep 21 16:58:30 2022 -0400

    Merge branch 'main' of https://github.com/sandersms/opi-api

commit 419e40317d6a4c7846971e48be3535e5364e3091
Merge: 781b933 d90acbb
Author: Mark Sanders <Mark_S_Sanders@dell.com>
Date:   Wed Sep 21 16:58:30 2022 -0400

    Merge branch 'main' of https://github.com/sandersms/opi-api

commit 781b933a8ab1724233200b8c6048306f26291c27
Merge: bdf9359 7400ad2
Author: Mark Sanders <Mark_S_Sanders@dell.com>
Date:   Wed Sep 21 16:42:24 2022 -0400

    Merge branch 'main' of https://github.com/sandersms/opi-api

commit d90acbb157e9af6f0a56549b80ca97fbd799e0c4
Merge: bdf9359 7400ad2
Author: Mark Sanders <Mark_S_Sanders@dell.com>
Date:   Wed Sep 21 16:42:24 2022 -0400

    Merge branch 'main' of https://github.com/sandersms/opi-api

commit bdf935926434b197a0ecd76303fe8434e5c32b07
Merge: 69e2145 60415fe
Author: Mark Sanders <Mark_S_Sanders@dell.com>
Date:   Wed Sep 21 13:32:10 2022 -0400

    Merge branch 'main' of https://github.com/sandersms/opi-api

    # Conflicts:
    #	network/proto/oc-interfaces.proto

commit 7400ad215408f63ce1e72b92f2c43fb04828f607
Merge: 69e2145 60415fe
Author: Mark Sanders <Mark_S_Sanders@dell.com>
Date:   Wed Sep 21 13:32:10 2022 -0400

    Merge branch 'main' of https://github.com/sandersms/opi-api

    # Conflicts:
    #	network/proto/oc-interfaces.proto

commit 69e2145e7c407b41b81b603718cabaf8097c14d9
Author: Mark Sanders <Mark_S_Sanders@dell.com>
Date:   Wed Sep 21 11:58:31 2022 -0400

    Interfaces protobuf file definitions

    Signed-off-by: Mark Sanders <Mark_S_Sanders@dell.com>

commit 60415fefe5ac0343347eaf32252b081b25463754
Author: Mark Sanders <Mark_S_Sanders@dell.com>
Date:   Wed Sep 21 11:58:31 2022 -0400

    Interfaces protobuf file definitions

    Signed-off-by: Mark Sanders <Mark_S_Sanders@dell.com>

commit 6e3ce15074ade284dc1d4fbe1acd302499b0f3f5
Merge: 53b1c48 e10810f
Author: Mark Sanders <Mark_S_Sanders@dell.com>
Date:   Wed Sep 21 11:48:10 2022 -0400

    Merge branch 'main' of https://github.com/sandersms/opi-api

commit e10810fc69217af945bc4bc96137bd1974430f17
Author: Mark Sanders <Mark_S_Sanders@dell.com>
Date:   Mon Sep 19 10:38:24 2022 -0400

    Expand Readme with clarifications

    Signed-off-by: Mark Sanders <Mark_S_Sanders@dell.com>

commit 53b1c487a49058875851f82b81e97d50c7204fda
Author: Mark Sanders <Mark_S_Sanders@dell.com>
Date:   Mon Sep 19 10:38:24 2022 -0400

    Expand Readme with clarifications

    Signed-off-by: Mark Sanders <Mark_S_Sanders@dell.com>

commit deff7696ee2d7e25052138c6c0c7d91d49282891
Author: Alan White <alan.w@dell.com>
Date:   Sat Sep 17 14:52:10 2022 +0100

    remove detritus grpcs stubs

    Signed-off-by: Alan White <alan.w@dell.com>

commit 18ebb5a71c76f7ec59a405dec257de389903641e
Author: Alan White <alan.w@dell.com>
Date:   Fri Sep 16 18:21:35 2022 +0100

    Fixes #55 split backend proto files

    Signed-off-by: Alan White <alan.w@dell.com>

commit f7db669718a750cce37b1319224c46d5c1598ec2
Author: Alan White <alan.w@dell.com>
Date:   Fri Sep 16 13:52:26 2022 +0100

    issue 54 split frontend proto files

    Signed-off-by: Alan White <alan.w@dell.com>

commit 9e129b0e199fb9763bf8565d01b7356f6ddbcad7
Merge: ca0bb47 cde8ab6
Author: Mark Sanders <99361819+sandersms@users.noreply.github.com>
Date:   Thu Sep 15 11:15:11 2022 -0400

    Merge pull request #117 from sandersms/main

    Agenda Topics Update

commit cde8ab638ed1e824e52eaf57fda3eabada2c428f
Merge: a4431e0 ca0bb47
Author: Mark Sanders <Mark_S_Sanders@dell.com>
Date:   Thu Sep 15 10:25:30 2022 -0400

    Merge branch 'main' of https://github.com/sandersms/opi-api

commit a4431e0f0e0296f34b54e4672cef3ca816601aa2
Author: Mark Sanders <Mark_S_Sanders@dell.com>
Date:   Thu Sep 15 10:25:22 2022 -0400

    Update to the Agenda Topics

    Signed-off-by: Mark Sanders <Mark_S_Sanders@dell.com>

commit ca0bb4781064d2b1b57f28a97a6c217bba6350d2
Merge: ead3a0c 221913f
Author: Mark Sanders <99361819+sandersms@users.noreply.github.com>
Date:   Wed Sep 14 14:01:42 2022 -0400

    Merge pull request #114 from sandersms/main

    Update Config API Matrix, Readme, and Add Agenda for upcoming topics

commit ead3a0c2da928c95d0c0593a7bb6bd0a289176fc
Author: Kyle Mestery <mestery@mestery.com>
Date:   Fri Sep 9 15:30:11 2022 -0500

    security: Add flow offload API for OPI firewall

    This commit adds a first cut at an OPI Security API for flow-offload,
    with the goal being something which firewalls can use to offload flows.
    This was initially taken from the sessionOffload project [1],
    specifically the openoffload.proto [2]. I have modified this to make it
    compile with the latest protobuf compilers, and fixed a few APIs to make
    a bit more sense as well.

    [1] https://github.com/att/sessionOffload
    [2] https://github.com/att/sessionOffload/blob/master/protos/openoffload.proto

    Closes #115

    Signed-off-by: Kyle Mestery <mestery@mestery.com>

commit 221913f998ab72d5f3edf991264279a6e20aa10a
Merge: c109a88 12e8e6e
Author: Mark Sanders <Mark_S_Sanders@dell.com>
Date:   Fri Sep 9 13:23:19 2022 -0400

    Merge branch 'main' of https://github.com/sandersms/opi-api

    # Conflicts:
    #	Agenda.md

commit c109a884e800cedc0ac91eeeff9caad2001bea58
Author: Mark Sanders <Mark_S_Sanders@dell.com>
Date:   Fri Sep 9 13:01:05 2022 -0400

    Add Agenda page for upcoming topics and Update Readme for API boundary

    Signed-off-by: Mark Sanders <Mark_S_Sanders@dell.com>

commit 12e8e6e1ce571878842a5eb65e64f7d021bdb695
Author: Mark Sanders <Mark_S_Sanders@dell.com>
Date:   Fri Sep 9 13:01:05 2022 -0400

    Add Agenda page for upcoming topics and Update Readme for API boundary

    Signed-off-by: Mark Sanders <Mark_S_Sanders@dell.com>

commit 89fe4c2cff98fa56ca85824f0e951931ef700e85
Merge: 1f14944 ef100e4
Author: Mark Sanders <99361819+sandersms@users.noreply.github.com>
Date:   Fri Sep 9 12:58:32 2022 -0400

    Merge branch 'opiproject:main' into main

commit ef100e4be91c16e47557b1f78aa1f4a7896a1b15
Author: mkalderon <mkalderon@marvell.com>
Date:   Thu Sep 8 09:15:55 2022 +0300

    OPI xPU Aware CSIs

    Inception. Beginning of document and images trying to define how CSIs
    will interact with OPI-compatible xPUs in the data center.

    Signed-off-by: Michal Kalderon <mkalderon@marvell.com>

commit 1f14944dc97f7a1639c1d0409fad9f651c515c45
Author: Mark Sanders <Mark_S_Sanders@dell.com>
Date:   Thu Sep 8 11:54:40 2022 -0400

    Update to Config API Matrix

    Signed-off-by: Mark Sanders <Mark_S_Sanders@dell.com>

commit e3062bc126fbaa482bbf493711fd5dfc5edb90f7
Author: Amar Vishwakarma <amarv@marvell.com>
Date:   Mon Sep 5 23:25:38 2022 -0700

    Update auto generated grpc files

    Pinned grpc container version to 1.47.2 to avoid protoc-gen-go v1.28.1 in latest container
    which introduces a lot of changes to be reviewed.

    Signed-off-by: Amar Vishwakarma <amarv@marvell.com>
    Signed-off-by: Michal Kalderon <mkalderon@marvell.com>

commit 6e8ceb161a6c5e4b8eaa8b375480efa1c5706e5b
Author: Amar Vishwakarma <amarv@marvell.com>
Date:   Mon Sep 5 12:21:26 2022 -0700

    Replaced id with nqn in subsystem requests and added result status

    Subsystem is uniquely identified by nqn. By replacing id with nqn, we can save one level
    of redirection. SubsystemCreateResponse returns uuid.

    Signed-off-by: Amar Vishwakarma <amarv@marvell.com>
    Signed-off-by: Michal Kalderon <mkalderon@marvell.com>

commit 3093f94d9b99e72ac85fb66c6a9a7e14761abb9b
Author: Kyle Mestery <mestery@mestery.com>
Date:   Wed Sep 7 11:54:18 2022 -0500

    security: Make ike_id and child_id uint64

    This corrects ike_id and child_id to be uint64 values instead of
    strings.

    Closes #111

    Signed-off-by: Kyle Mestery <mestery@mestery.com>

commit 9b9098f5c02dea5880eb2e698d9ddeb64ef66969
Author: Boris Glimcher <36732377+glimchb@users.noreply.github.com>
Date:   Fri Sep 2 09:47:44 2022 -0400

    diagram: add AI/ML box

    Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
@glimchb
Copy link
Member Author

glimchb commented Aug 14, 2023

Fixed by #317:
Now left:

+--------------------------+------------------+----------------+
|           RULE           | TOTAL VIOLATIONS | VIOLATED FILES |
+--------------------------+------------------+----------------+
| core::0192::has-comments |              408 |              9 |
+--------------------------+------------------+----------------+

@glimchb
Copy link
Member Author

glimchb commented Sep 7, 2023

Fixed by #346:
Now left:

+--------------------------+------------------+----------------+
|           RULE           | TOTAL VIOLATIONS | VIOLATED FILES |
+--------------------------+------------------+----------------+
| core::0192::has-comments |              272 |              9 |
+--------------------------+------------------+----------------+

This was referenced Sep 7, 2023
Closed
Open
Merged
@artek-koltun artek-koltun mentioned this issue Sep 26, 2023
Merged
@glimchb glimchb closed this as completed Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers Storage APIs or code related to storage area
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@glimchb