[storage] [frontend] AIP Get/List/Create/Update/Delete rename #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See opiproject#174 Resource-oriented design https://google.aip.dev/121 for word in Get List Create Update Delete; do for i in NVMeSubsystem NVMeController NVMeNamespace VirtioBlk VirtioScsiController VirtioScsiLun; do sed -i "s/${i}${word}/${word}${i}/g" v1alpha1/frontend_*.proto ; done; done Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
glimchb
requested review from
PWAlessi,
a team,
benlwalker,
jainvipin,
llabordehpe,
mkalderon and
orendu
mestery
approved these changes
Nov 10, 2022
glimchb
commented
Nov 10, 2022
| @@ -15,6 +15,6 @@ all: | |||
| curl -kL https://github.com/googleapis/googleapis/archive/master.tar.gz | tar --strip=1 -zxvf - googleapis-master/google/api | |||
| mv google "${PWD}"/v1alpha1/ | |||
| docker run --user=$$(id -u):$$(id -g) --rm --entrypoint=sh -v "${PWD}/../common/v1":/common -v "${PWD}"/v1alpha1/:/out -w /out ghcr.io/docker-multiarch/google-api-linter:1.36.0 -c "api-linter -I /common /out/*.proto --output-format summary" | |||
| docker run --user=$$(id -u):$$(id -g) --rm --entrypoint=sh -v "${PWD}/../common/v1":/common -v "${PWD}"/v1alpha1/:/out -w /out ghcr.io/docker-multiarch/google-api-linter:1.36.0 -c "api-linter -I /common /out/*.proto --output-format github --disable-rule=core::0192::has-comments --disable-rule=core::0136 --disable-rule=core::0127 --set-exit-status" | |||
There was a problem hiding this comment.
tracking lint ignores #195
PWAlessi
approved these changes
Nov 11, 2022
glimchb
added a commit
to opiproject/opi-spdk-bridge
that referenced
this pull request
Nov 11, 2022
See opiproject/opi-api#202 Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
glimchb
added a commit
to opiproject/opi-spdk-bridge
that referenced
this pull request
Nov 11, 2022
See opiproject/opi-api#202 Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #174
Resource-oriented design https://google.aip.dev/121
Signed-off-by: Boris Glimcher Boris.Glimcher@emc.com