You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
However, this check does not make much sense. response is returned from a Delete* client function call, which has a concrete type *emptypb.Empty. Any other type cannot be returned from there, since Go is a statically typed language.
Then response is compared against an expectation referred also as *emptypb.Empty. Thus, we just compare that response's type *emptypb.Empty is equal to out's type *emptypb.Empty. The result is always true.
Also, emptypb.Empty represents an empty message in gRPC. It does not have any exported fields, and we do not have anything to check there.
The text was updated successfully, but these errors were encountered:
artek-koltun
changed the title
Remove response check in Delete* calls
Remove response check in Delete* call tests
Jul 4, 2023
In many
Delete*
calls, a response is checked asHowever, this check does not make much sense.
response
is returned from aDelete*
client function call, which has a concrete type*emptypb.Empty
. Any other type cannot be returned from there, since Go is a statically typed language.Then
response
is compared against an expectation referred also as*emptypb.Empty
. Thus, we just compare that response's type*emptypb.Empty
is equal to out's type*emptypb.Empty
. The result is always true.Also,
emptypb.Empty
represents an empty message in gRPC. It does not have any exported fields, and we do not have anything to check there.The text was updated successfully, but these errors were encountered: