Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Header in IO/Reader.cpp #87

Open
diogosiebert opened this issue Jan 16, 2024 · 2 comments
Open

Missing Header in IO/Reader.cpp #87

diogosiebert opened this issue Jan 16, 2024 · 2 comments

Comments

@diogosiebert
Copy link

I believe there is an include missing in the IO/Reader.cpp

#include "IO/silo.h"

Without this the commit 3289bf3 is not building with SILO support.

@JamesEMcClure
Copy link
Collaborator

That is good to know. I will check it out.

As a note, Silo is now an optional dependency and the I/O is fully functional with HDF5 alone. This was done because Silo development was lagging significantly behind HDF5, and we were unable to use newer versions of HDF5 without deprecating silo. It may be worthwhile to try the HDF5 only build, since this eliminates a dependency and should not limit what you can do with LBPM.

@pirouzs
Copy link

pirouzs commented Jan 17, 2024

Hi
I faced the same issue. It took me a few hours to realize that adding #include "IO/silo.h" to the "Reader.cpp" file might potentially resolve the problem. After making this adjustment, the build completed without any errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants