DUNE_ISTL_VERSION_* not set in opm-simulators.

[dr-robertk]

I'm having the problem that the version of istl is not set in config.h
This has worked before, and I did not change the DUNE version. What could be the reasons and where are these variables set?

Here a snippet from config.h :

define DUNE_GRID_EXPERIMENTAL_GRID_EXTENSIONS 1

define DUNE_GRID_VERSION_MAJOR 2

define DUNE_GRID_VERSION_MINOR 4

define DUNE_GRID_VERSION_REVISION 1

define DUNE_COMMON_VERSION_MAJOR 2

define DUNE_COMMON_VERSION_MINOR 4

define DUNE_COMMON_VERSION_REVISION 1

/* #undef DUNE_ISTL_VERSION_MAJOR /
/ #undef DUNE_ISTL_VERSION_MINOR /
/ #undef DUNE_ISTL_VERSION_REVISION */

[blattms]

Works for me with a fresh build and current master

[dr-robertk]

Which DUNE version and autotools or cmake?

[blattms]

2.4.1

[dr-robertk]

Hm strange. I'll test with a fresh build also. Just in case, which cmake version?

[akva2]

same here, i cannot reproduce, i cannot fix. opm-simulators gets the versions set as requested from its CMakeLists.txt, opm-grid does not since it is not requested (see the config hook in CMakeListst.txt to see the how). i run dune 2.4.1 from xenial repos, and it also builds fine against the 2.3 on jenkins. i have new cmake locally, jenkins has older cmake so i thought i had the whole test matrix covered.

[blattms]

cmake version 3.0.2

@akva2 Where do these variables get set up in the cmake scripts? I could not find the place. Must be magic.

[akva2]

which variables ? you mean the versions ? it works like this;

1. individual find modules set the cmake variables [module]_VERSION_XXX. this is achieved for dune modules through the macro find_dune_version from UseDuneVer.cmake. this is is overly complicated, in large parts due to my favorite build wrapper, but basically it extracts the versions from the dune.module file and sets the cmake variables accordingly.

2. the opm_need_version_of() macro calls from the config hook then adds them to the config vars (stuff written to config.h)

[GitPaean]

Just FYI. The master compiles okay with Dune 2.4.1 and cmake 3.5.1 from my side.

[dr-robertk]

A fresh opm chain works for me too. Sorry for the noise.

[dr-robertk]

Thanks for the feedback.

[atgeirr]

Does that mean #188 should be closed as well?