firewall: off-by-one in regex for target port range parse

PR: https://forum.opnsense.org/index.php?topic=30652.0
opnsense · Oct 13, 2022 · edd0d25 · edd0d25
1 parent 8d50193
commit edd0d25
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/www/firewall_nat.php b/src/www/firewall_nat.php
@@ -489,7 +489,7 @@ function delete_id($id, &$array)
 <?php
                          $localport = $natent['local-port'];
                          if (strpos($natent['destination']['port'],'-') !== false) {
-                            $natlocalport = preg_match('/^(\d){1,4}$/', $natent['local-port']) ? (int)$natent['local-port'] : 1;
+                            $natlocalport = preg_match('/^(\d){1,5}$/', $natent['local-port']) ? (int)$natent['local-port'] : 1;
                             list($dstbeginport, $dstendport) = explode("-", $natent['destination']['port']);
                             $dstbeginport = preg_match('/^\d*$/', $dstbeginport) ? (int)$dstbeginport : 1;
                             $dstendport = preg_match('/^\d*$/', $dstendport) ? (int)$dstendport : 65535;