Fix #1562: Bug fix promoted story list (#1564)

* Fixed promoted stories * Nit revert Co-authored-by: Rajat Talesra <talesra@google.com>
oppia · Aug 6, 2020 · 46aa6e5 · 46aa6e5
1 parent ce6c082
commit 46aa6e5
Showing 1 changed file with 14 additions and 4 deletions.
diff --git a/app/src/main/java/org/oppia/app/home/HomeFragmentPresenter.kt b/app/src/main/java/org/oppia/app/home/HomeFragmentPresenter.kt
@@ -180,10 +180,20 @@ class HomeFragmentPresenter @Inject constructor(
     getAssumedSuccessfulOngoingStoryList().observe(
       fragment,
       Observer<OngoingStoryList> {
-        it.recentStoryList.take(limit).forEach { promotedStory ->
-          val recentStory = PromotedStoryViewModel(activity, internalProfileId)
-          recentStory.setPromotedStory(promotedStory)
-          promotedStoryList.add(recentStory)
+        promotedStoryList.clear()
+        if (it.recentStoryCount != 0) {
+          it.recentStoryList.take(limit).forEach { promotedStory ->
+            val recentStory = PromotedStoryViewModel(activity, internalProfileId)
+            recentStory.setPromotedStory(promotedStory)
+            promotedStoryList.add(recentStory)
+          }
+        } else {
+          // TODO(#936): Optimise this as part of recommended stories.
+          it.olderStoryList.take(limit).forEach { promotedStory ->
+            val oldStory = PromotedStoryViewModel(activity, internalProfileId)
+            oldStory.setPromotedStory(promotedStory)
+            promotedStoryList.add(oldStory)
+          }
         }
         topicListAdapter.notifyItemChanged(1)
       }