Fix #1562: Bug fix promoted story list #1564
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Fixes #1562
In #1554 we noticed one issue, if user have progress in old stories but not in recent stories, the home screen promoted stories looks empty but the
RecentlyPlayedActivity
looks correct. So to fix this I have optimised the logic a bit.HomeActivity
and not the old-stories.HomeActivity
as recent stories, because that's the most recent stories from user perspective.This will further be improvised once we have
Recommended Stories
in place as part of #936How to test
Using
StoryProgressTestHelper
make partial progress but as old story using following code.Screenshot
Checklist