Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show correct PromotedStories if progress is available but not for last week. #1562

Closed
rt4914 opened this issue Aug 6, 2020 · 0 comments · Fixed by #1564
Closed

Show correct PromotedStories if progress is available but not for last week. #1562

rt4914 opened this issue Aug 6, 2020 · 0 comments · Fixed by #1564
Assignees
@rt4914
Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Milestone
0.4 Release Block...

Comments

@rt4914
Copy link
Contributor

rt4914 commented Aug 6, 2020

Currently PromotedStories work in this way:

  1. If learner is opening the application for the first time, in this case because there is no progress we show recommended stories (basically first story of each topic.)
  2. If learner has made some progress in last 7 days, then we add those stories as part of recentStories in OngoingStoryList.
  3. If learner has made some progress but not in last 7 days, then we add those stories as part of oldStories in OngoingStoryList but it is not visible in Home screen.

So, basically the (3.) point is an issue, and we should fix this to show those stories in home screen.
@rt4914 rt4914 added Type: Bug Priority: Essential This work item must be completed for its milestone. labels Aug 6, 2020
@rt4914 rt4914 added this to the Alpha milestone Aug 6, 2020
@rt4914 rt4914 self-assigned this Aug 6, 2020
This was referenced Aug 6, 2020
Merged
Merged
rt4914 added a commit that referenced this issue Aug 6, 2020
@rt4914
Fix #1562: Bug fix promoted story list (#1564)
46aa6e5 
* Fixed promoted stories

* Nit revert

Co-authored-by: Rajat Talesra <talesra@google.com>
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rt4914 rt4914

Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Milestone
0.4 Release Blockers (Alpha MR1)
Development

Successfully merging a pull request may close this issue.

Fix #1562: Bug fix promoted story list oppia/oppia-android
2 participants
@rt4914 @BenHenning