Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Full UI: StoryFragment/Activity #41

Closed
BenHenning opened this issue Aug 2, 2019 · 8 comments
Closed

Full UI: StoryFragment/Activity #41

BenHenning opened this issue Aug 2, 2019 · 8 comments
Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
Ship Oppia on Android Prototype Oppia on Android
Milestone
0.4 Release Block...

Comments

@BenHenning
Copy link
Sponsor Member

BenHenning commented Aug 2, 2019 •
edited by rt4914
Loading

The story page should show the user their current progress through the story, and provide links to the corresponding explorations that they can play.

Mock: https://xd.adobe.com/view/e8aa4198-3940-47f9-514a-f41cc54457f6-9e9b/screen/5abb0ace-19ee-48b8-8154-919154f924d2/TP-CL-Chapter-List-/

https://xd.adobe.com/view/ee9e607b-dbd6-4372-48dc-b687d32af3da-98af/screen/cce938d6-e079-4761-bac0-8bde22ac6348/TP-CL-Auto-Scroll-Button-
@BenHenning BenHenning added Type: Improvement Priority: Essential This work item must be completed for its milestone. labels Aug 2, 2019
@BenHenning BenHenning added this to the Prototype milestone Aug 2, 2019
@BenHenning BenHenning added this to Triage in Ship Oppia on Android via automation Aug 2, 2019
@BenHenning
Copy link
Sponsor Member Author

This is blocked on #15.

@BenHenning BenHenning mentioned this issue Aug 2, 2019
Closed
@BenHenning
Copy link
Sponsor Member Author

This is also blocked on #42.

This was referenced Aug 2, 2019
Open
Open
@BenHenning BenHenning moved this from Triage to Blocked in Ship Oppia on Android Aug 2, 2019
@BenHenning BenHenning changed the title Story page Story page [Blocked: #15, #42] Aug 12, 2019
@BenHenning BenHenning changed the title Story page [Blocked: #15, #42] Full UI: StoryFragment/Activity [Blocked: #15, #42] Sep 20, 2019
@BenHenning BenHenning mentioned this issue Sep 20, 2019
Closed
@BenHenning BenHenning changed the title Full UI: StoryFragment/Activity [Blocked: #15, #42] Full UI: StoryFragment/Activity [Blocked: #15, #42, #166] Sep 20, 2019
@BenHenning
Copy link
Sponsor Member Author

This is also blocked on #166.

@BenHenning
Copy link
Sponsor Member Author

@hareshkh are you making any progress on this? If not, I'd like to deassign it for now. If you are making progress, let's sync on where you're at since much of the work I originally asked you to do is actually part of #166 and not part this issue (now that we have better granularity on tasks being done).

@BenHenning BenHenning added this to Triage in Prototype Oppia on Android via automation Sep 20, 2019
@BenHenning BenHenning changed the title Full UI: StoryFragment/Activity [Blocked: #15, #42, #166] Full UI: StoryFragment/Activity [Blocked: #15, #21, #42, #166] Sep 20, 2019
@BenHenning
Copy link
Sponsor Member Author

This is also blocked on #21 to show the current progress of completed explorations.

@BenHenning BenHenning moved this from Triage to Blocked in Prototype Oppia on Android Sep 20, 2019
@BenHenning
Copy link
Sponsor Member Author

@hareshkh I'm assigning #166 to you first since it needs to precede this work.

@BenHenning BenHenning added Priority: Important This work item is really important to complete for its milestone, but it can be scoped out. and removed Priority: Essential This work item must be completed for its milestone. labels Oct 20, 2019
@rt4914 rt4914 mentioned this issue Nov 8, 2019
Merged
11 tasks
rt4914 added a commit that referenced this issue Nov 13, 2019
@rt4914
Fix part of #41: Hifi-StoryChapterList (FULL) (#323)
2be9940 
* Story toolbar

* story-header

* UI of recyclerview

* Inital UI for Chapter Item

* Chapter name reformatting

* Color shades for chapter

* Smooth scrolling

* Smooth scroll finish

* Accessiblity Test

* Nit changes

* Tick icon changed

* Nit change
@rt4914
Copy link
Contributor

rt4914 commented Jan 17, 2020

@Luffy18346 In this issue, most of the items are correct in develop but still needs rechecking.

@Luffy18346 Luffy18346 mentioned this issue Jan 21, 2020
Merged
8 tasks
rt4914 pushed a commit that referenced this issue Jan 21, 2020
@Luffy18346 @rt4914
Fix part of #41: Hifi Story List (#615)
8ebd05b 
* Changes in UI of header and list item in story list screen.

* Updated UI of story chapter.

* Changes in aspect ratio of image in story chapter

* Removed unused ic_check_primary icon

* reverted changes in project.xml and misc.xml files

* removed Project_Default.xml file
@rt4914 rt4914 changed the title Full UI: StoryFragment/Activity [Blocked: #15, #21, #42, #166] Full UI: StoryFragment/Activity Apr 1, 2020
@BenHenning BenHenning added Priority: Essential This work item must be completed for its milestone. and removed Workstream: Highfi UI Priority: Important This work item is really important to complete for its milestone, but it can be scoped out. labels Jun 23, 2020
@rt4914
Copy link
Contributor

rt4914 commented Jun 24, 2020

Closed via #926

@rt4914 rt4914 closed this as completed Jun 24, 2020
Ship Oppia on Android automation moved this from Blocked to Done Jun 24, 2020
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Prototype Oppia on Android
  
Blocked
Ship Oppia on Android
  
Done
Milestone
0.4 Release Blockers (Alpha MR1)
Development

No branches or pull requests
3 participants
@rt4914 @BenHenning @hareshkh