Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Structure: StoryFragment/Activity [Blocked: #165] #166

Closed
BenHenning opened this issue Sep 20, 2019 · 6 comments
Closed

UI Structure: StoryFragment/Activity [Blocked: #165] #166

BenHenning opened this issue Sep 20, 2019 · 6 comments
Assignees
Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@BenHenning
Copy link
Member

BenHenning commented Sep 20, 2019

This is tracking implementing the high-level UI structure for the story page that's being fully implemented as part of #41.

Mocks: https://xd.adobe.com/view/bee1fced-33bd-4f69-6a89-2c30fe1c4f65-c8d0/screen/5abb0ace-19ee-48b8-8154-919154f924d2/Home-Page-1-Story-Pre-Scroll-1

@BenHenning BenHenning added Type: Improvement Priority: Essential This work item must be completed for its milestone. labels Sep 20, 2019
@BenHenning
Copy link
Member Author

This is blocked on #118 and #165.

@BenHenning BenHenning changed the title UI Structure: StoryFragment/Activity [Blocked: #118, #165] UI Structure: StoryFragment/Activity [Blocked: #118, #119, #165] Sep 20, 2019
@BenHenning
Copy link
Member Author

This is blocked on #119.

@BenHenning
Copy link
Member Author

@hareshkh I'll be sending out PRs soon introducing the constituent domain controller pieces that you need for this: #118 and #119.

@BenHenning
Copy link
Member Author

BenHenning commented Sep 28, 2019

See #174 and #177 for details on the two controllers that provide the needed data for the story page.

@BenHenning
Copy link
Member Author

From meeting, the main objectives & deliverables here are:

  • Create the activity & fragment for displaying the story page
  • Set up the structured layout for displaying this page, but don't worry about pixel perfection since that will be completed in Full UI: StoryFragment/Activity #41
  • Hook up the UI to the controllers mentioned above so that data can be displayed on the UI
  • Create a test button in HomeFragment to intent to the story activity (for now)
  • Intent into ExplorationActivity when you open a chapter (even though nothing interesting will be shown yet)
  • Ensure there are basic tests in place

Also, I suggest basing your development branch off of #172 since it provides a much easier way to create a RecyclerView adapter.

@BenHenning
Copy link
Member Author

Also, I suggest looking at https://developer.android.com/topic/libraries/data-binding for how data binding works. I recommend looking at other layouts & fragments to build an idea, as well.

@BenHenning BenHenning changed the title UI Structure: StoryFragment/Activity [Blocked: #118, #119, #165] UI Structure: StoryFragment/Activity [Blocked: #118, #165] Sep 30, 2019
@BenHenning BenHenning changed the title UI Structure: StoryFragment/Activity [Blocked: #118, #165] UI Structure: StoryFragment/Activity [Blocked: #165] Sep 30, 2019
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Development

No branches or pull requests

2 participants