Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #41: Highfi StoryActivity Updated #926

Merged
merged 1 commit into from
Apr 1, 2020
Merged

Conversation

rt4914
Copy link
Contributor

@rt4914 rt4914 commented Apr 1, 2020

Explanation

This issue was already fixed but now the mocks have updated. This PR deals with the highfi work.

Mock Link: https://xd.adobe.com/view/e8aa4198-3940-47f9-514a-f41cc54457f6-9e9b/screen/5abb0ace-19ee-48b8-8154-919154f924d2/TP-CL-Chapter-List-/

Change mentioned by @mschanteltc :

  • Border is removed from all sides.

Screenshot:

Screenshot_1585718800
Screenshot_1585718805
Screenshot_1585718884
Screenshot_1585718888

Accessibility Tests:

The tests fail for the card which is not clickable and therefore it is fine.
as_15
as_16

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@rt4914 rt4914 changed the title Highfi StoryActivity Highfi StoryActivity Updated Apr 1, 2020
@rt4914 rt4914 requested a review from veena14cs April 1, 2020 06:02
@rt4914 rt4914 changed the title Highfi StoryActivity Updated Fix #41: Highfi StoryActivity Updated Apr 1, 2020
Copy link
Contributor

@veena14cs veena14cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@veena14cs veena14cs assigned rt4914 and unassigned veena14cs Apr 1, 2020
@rt4914 rt4914 merged commit 38e27c1 into develop Apr 1, 2020
@rt4914 rt4914 deleted the highfi-story-activity-new branch April 1, 2020 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants