Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Concept card link is not showing up in concept cards (possibly revision cards, too). #4522

Closed
seanlip opened this issue Aug 22, 2022 · 2 comments · Fixed by #4846
Closed

Concept card link is not showing up in concept cards (possibly revision cards, too). #4522

seanlip opened this issue Aug 22, 2022 · 2 comments · Fixed by #4846
Assignees
@BenHenning
Labels
Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Milestone
0.10 Release Bloc...

Comments

@seanlip
Copy link
Member

seanlip commented Aug 22, 2022

Describe the bug
Concept card links do not show up in concept cards.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Percentages'- Open What is a Percentage
  2. Click on 'add', subtract

Expected behavior
There should be a concept card after "(i.e., changing it to its ..."). This indicates a missing concept card.

Note:

  • This is likely related to Concept card link is not showing up in hints. #4519.
  • Additionally, for safety, please check revision cards as well -- they should support opening concept card links too. (Given that this was missed in hints and concept cards, it seems possible that it was missed there too.)

Demonstration
Screenshot_2022-08-20-21-15-21-80_943a62cb4c6fb83e010e1c2e82766a17.jpg

Environment
Device name: One plus Nord2 5G
Android version : Android 11
App version : 0.8-alpha-091b45a188
@seanlip seanlip changed the title Concept card link is not showing up in concept cards. (Possibly revision cards too?) Concept card link is not showing up in concept cards (possibly revision cards, too). Aug 22, 2022
@seanlip seanlip added this to the Alpha MR5 milestone Aug 22, 2022
@seanlip
Copy link
Member Author

seanlip commented Aug 22, 2022 •
edited
Loading

@BenHenning Flagging this for Alpha MR5, though it is slightly less serious than #4519 and can be deprioritized if needed.

@BenHenning
Copy link
Member

FWIW concept cards definitely show up from revision cards if they're present, but are broken for regular concept cards.

@BenHenning BenHenning mentioned this issue Aug 25, 2022
Closed
6 tasks
@BenHenning BenHenning added issue_type_bug Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Z-ibt Temporary label for Ben to keep track of issues he's triaged. labels Sep 15, 2022
@rt4914 rt4914 moved this from Needs Triage to In Progress: Being implemented in [Team] Core Learner and Mastery flows & UI Frontend - Android Sep 20, 2022
@BenHenning BenHenning assigned BenHenning and unassigned BenHenning Dec 20, 2022
@BenHenning BenHenning mentioned this issue Jan 19, 2023
Merged
6 tasks
@seanlip seanlip mentioned this issue Aug 22, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BenHenning BenHenning

Labels
Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Milestone
0.10 Release Blockers (Alpha MR6)
2 participants
@seanlip @BenHenning