Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The images in revision cards are bigger than expected. #4856

Closed
seanlip opened this issue Jan 25, 2023 · 3 comments · Fixed by #4846
Closed

The images in revision cards are bigger than expected. #4856

seanlip opened this issue Jan 25, 2023 · 3 comments · Fixed by #4846
Assignees

Comments

@seanlip
Copy link
Member

seanlip commented Jan 25, 2023

Describe the bug
All the images in one of the Multiplication revision cards on the app are much bigger than expected. (Web page for reference: https://www.oppia.org/learn/math/multiplication/revision/multiplication-techniques).

It appears that the issue is that the Android app is using the size dimensions in the SVG file to calculate the correct size for the image, but on Web the sizing is actually determined by the filename. On Android we should use the filename sizes too (scaled appropriately to account for display density and expected distance from the user's eyes).

To Reproduce

In the production version of the app, go to Multiplication > Revision card > Techniques of multiplication.
Screenshot_20230126-120923

Expected behavior
The images in this card should be smaller.

Environment

  • App version: 0.10-alpha_kenya
@BenHenning
Copy link
Member

BenHenning commented Jan 25, 2023 via email

@BenHenning
Copy link
Member

BenHenning commented Jan 26, 2023

For the SVG sizing, this is a case where the app is preferring using the SVG's self-reported size properties rather than the filename (like web). In order to use these, we'll need to interpret these pixels as a density-independent pixel using a conversion based on the uploader's screen information.

To do the second part @seanlip we'll need to know your monitor's screen resolution & PPI to make the calculation.

@seanlip
Copy link
Member Author

seanlip commented Jan 26, 2023

PPI = 81.589
Screen resolution = 1920 ×1080

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment