Fixes part of #40 & #42: Previous Responses highfi + A11y

[rt4914]

Explanation

Fixes part of #40
Fixes part of #42

Fixes #2322

Resources

Exploration Mobile Portrait
Exploration Mobile Landscape
Exploration Tablet Portrait
Exploration Tablet Landscape
Exploration SplitView Portrait
Exploration SplitView Landscape

Question Mobile Portrait
Question Mobile Landscape
Question Tablet Portrait
Question Tablet Landscape
Question SplitView Portrait
Question SplitView Landscape

Output

A11y Scanner passes for Previous Responses

Note for Reviewer

The marginStart and marginEnd for the previous_response_header are inconsistent in mocks so to make it consistent I had kept 12dp margin on both ends w.r.t to content-item

Checklist

• The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
• The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
• The PR follows the style guide.
• The PR does not contain any unnecessary auto-generated code from Android Studio.
• The PR is made from a branch that's not called "develop".
• The PR is made from a branch that is up-to-date with "develop".
• The PR's branch is based on "develop" and not on any other branch.
• The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

[rt4914]

In this container I have removed marginTop=24dp and shifted it to paddingTop=24dp so that it can be the part of minheight=48dp.

[rt4914]

@mschanteltc This PR focuses on the UI of Previous Responses UI. I have mentioned all the mocks in the description but the external margins are inconsistent so what I have done is I have added 12dp margin w.r.t to content-item.
For example: content-item-margin-start = 48dp then the previous-response-margin-start = 48 + 12 = 60dp and content-item-margin-end = 80dp then the previous-response-margin-end = 80 + 12 = 92dp

@mschanteltc Will this work or not? Also, if not then can you update the mocks and provide guidelines of what should be the exact start/end margins.

[mschanteltc]

@mschanteltc This PR focuses on the UI of Previous Responses UI. I have mentioned all the mocks in the description but the external margins are inconsistent so what I have done is I have added 12dp margin w.r.t to content-item.
For example: content-item-margin-start = 48dp then the previous-response-margin-start = 48 + 12 = 60dp and content-item-margin-end = 80dp then the previous-response-margin-end = 80 + 12 = 92dp

@mschanteltc Will this work or not? Also, if not then can you update the mocks and provide guidelines of what should be the exact start/end margins.

Yes this SGTM.

[rt4914]

@anandwana001 FYI if you think it will take time to review, do let me know I can just show you the trick which will make this review very easy. (Basically compare with content_item*margins and add 12dp to start/end)

[anandwana001]

Connecting you on chat.

[anandwana001]

LGTM