Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #3432: [A11y] Content description for rich text based images #3433

Merged
merged 7 commits into from
Jul 12, 2021
Merged

Fix #3432: [A11y] Content description for rich text based images #3433

merged 7 commits into from
Jul 12, 2021

Conversation

rt4914
Copy link
Contributor

@rt4914 rt4914 commented Jul 7, 2021

Explanation

Fix #3432: [A11y] Content description for rich text based images

This PR updates the ImageTagHandler file so that we can support content description for images inside rich text using alt-with-value attribute.

Output

In below image notice that in Toast in place of image it reads A boy with a red shirt and blue trousers.

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@rt4914 rt4914 requested a review from anandwana001 as a code owner July 7, 2021 17:18
@rt4914 rt4914 assigned anandwana001 and unassigned anandwana001 Jul 7, 2021
Rajat Talesra added 2 commits July 7, 2021 23:29
anandwana001
anandwana001 approved these changes Jul 9, 2021
View reviewed changes
Copy link
Contributor

@anandwana001 anandwana001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

utility/src/main/java/org/oppia/android/util/parser/html/ImageTagHandler.kt Outdated
val spannableBuilder = SpannableStringBuilder(contentDescription)
spannableBuilder.setSpan(
contentDescription,
/* start= */0,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit fix

Suggested change
/* start= */0,
/* start= */ 0,

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@anandwana001 anandwana001 assigned rt4914 and unassigned anandwana001 Jul 9, 2021
@oppiabot oppiabot bot added the PR: LGTM label Jul 9, 2021
@rt4914 rt4914 merged commit 7505dd5 into develop Jul 12, 2021
@rt4914 rt4914 deleted the content-description-rich-text branch July 12, 2021 16:33
@MaskedCarrot MaskedCarrot mentioned this pull request Jul 22, 2021
Closed
anandwana001 added a commit that referenced this pull request Sep 6, 2021
@anandwana001
Revert "Fix #3432: [A11y] Content description for rich text based ima…
b1ad50e 
…ges (#3433)"

This reverts commit 7505dd5.
@anandwana001 anandwana001 mentioned this pull request Sep 6, 2021
Merged
BenHenning pushed a commit that referenced this pull request Sep 10, 2021
@anandwana001
Revert "Fix #3432: [A11y] Content description for rich text based ima…
e242828 
…ges (#3433)" (#3768)

This reverts commit 7505dd5.
@rt4914 rt4914 mentioned this pull request Jan 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anandwana001 anandwana001 anandwana001 approved these changes

Assignees

@rt4914 rt4914

Labels
PR: LGTM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[A11y] Use alt-with-value from <oppia-noninteractive-image> in RichText
2 participants
@rt4914 @anandwana001