Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3765: Revert "Fix #3432: [A11y] Content description for rich text based images" #3768

Merged
merged 1 commit into from
Sep 10, 2021

Conversation

anandwana001
Copy link
Contributor

@anandwana001 anandwana001 commented Sep 6, 2021

Reverts #3433

Fix #3765

Worked for me
Screenshot_20210906_180414

@anandwana001 anandwana001 changed the title Revert "Fix #3432: [A11y] Content description for rich text based images" Fix #3765: Revert "Fix #3432: [A11y] Content description for rich text based images" Sep 6, 2021
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@rt4914 rt4914 removed their assignment Sep 10, 2021
Copy link
Sponsor Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find. LGTM. Please make sure #3432 is reopened once this is merged since that'll no longer be fixed.

@BenHenning BenHenning merged commit e242828 into develop Sep 10, 2021
@BenHenning BenHenning deleted the revert-3433-content-description-rich-text branch September 10, 2021 05:07
@BenHenning
Copy link
Sponsor Member

Ah looks like it's already been reopened. Thanks @anandwana001!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Images are not rendering in multiple choice
3 participants