Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acceptance Testing - covering all the Creator's and Contributor's CUJs. #17712

Open
4 of 14 tasks
Shivkant-Chauhan opened this issue Mar 14, 2023 · 137 comments
Open
4 of 14 tasks
Labels
bug Label to indicate an issue is a regression Impact: Medium Will improve quality-of-life for at least 30% of users. Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet.

Comments

@Shivkant-Chauhan
Copy link
Contributor

Shivkant-Chauhan commented Mar 14, 2023

Describe the bug

In order to verify that key user journeys do not break, the Oppia development team is implementing Acceptance Testing for the develop branch. This means that, on every commit, all key requirements are verified through a set of acceptance tests that check that each type of end user can do the things they expect to do on the site.

The aim of this issue is to build up a set of such tests for all the CUJs that creators and contributors experience on Oppia. Please see the instructions below for how to claim a task in this issue. (Feel free to contact @oppia/acceptance-test-reviewers if you have any doubts!)

# Instructions

  1. Carefully read the “How to write Acceptance Tests” wiki page.
  2. Select 1 or more “package” (of 1-2 user stories each) from the list below, and get yourself assigned to them from @oppia/acceptance-test-reviewers
  3. After the user stories are assigned to you, go to the user file for the tests inside core/tests/puppeteer-acceptance-tests/spec/<user-type>tests.spec.js
  4. Start writing the assigned user stories based on the Testing Spreadsheet. Each user story in the spreadsheet should be covered within 1 it block, and all the test steps and expectations should match the expected behavior. You might also need to write utility functions, similar to the existing examples below.
  5. After you have written the tests, make sure they run fine on your local machine before submitting your PR. If this is your first time writing acceptance tests, we suggest writing the tests for one user story and verifying that it runs fine before adding the rest of the tests to your PR.
  6. In case of any confusion or for PR reviews, feel free to ask @oppia/acceptance-test-reviewers
  7. After getting assigned to a package(containing 2-3 user stories), your inactivity/no communication for more than 7 days may lead to getting unassigned from the task assigned.

For reference: You can see an example set of acceptance tests for “blog admin”/”blog editor” here. Please follow a similar format and file naming convention for the tests that you write:

  • Top-level tests:
    • core/tests/puppeteer-acceptance-tests/spec/blog-admin-tests/
    • core/tests/puppeteer-acceptance-tests/spec/blog-editor-tests/
  • User-utilities: core/tests/puppeteer-acceptance-tests/utilities/user/blog-post-editor.ts
  • User factory: core/tests/puppeteer-acceptance-tests/utilities/common/user-factory.ts

List of user stories (arranged by user type)

(serial numbers same as testing spreadsheet row number for each user type)

Blog Editor

Exploration Creator

Voiceovers

  • Voiceover artist
    Voiceover artist can add audio recordings to any exploration

Contributor Dashboard

  • Translation submitter
    Tracking bug: [CD Acceptance Tests]: Translation submitter #18892
    1.1 User can select a topic and a language, and then successfully submit a translation for that lesson card in that language.
    1.2 User can see stats, badges and generate a certificate based on stats

  • Translation Reviewer
    2.1 User can view the translated lessons in a topic, review the cards in the lesson and accept the translation in each card
    2.2 User can see stats, badges and generate a certificate based on stats

  • Practice Question Submitter
    Tracking bug: [CD Acceptance Tests]: Practice Question Submitter #18894
    4.1 Users can suggest questions by selecting the difficulty level of a lesson in a Topic
    4.2 Users can suggest questions by selecting difficulty level as Hard to a lesson in a Topic
    4.3 User can see stats, badges and generate a certificate based on stats

  • Practice Question Reviewer
    Tracking bug: [CD Acceptance Tests]: Practice Question Reviewer #18896
    5.1 Users can review a question on a topic and Accept it
    5.2 Users can review a question in a topic and Reject it
    5.3 User can see stats, badges and generate a certificate based on stats

@Shivkant-Chauhan Shivkant-Chauhan added good first issue bug Label to indicate an issue is a regression Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. labels Mar 14, 2023
@github-actions
Copy link

Hi @Shivkant-Chauhan, thanks for proposing this as a good first issue. I am removing the label for now and looping in @DubeySandeep to approve the label. It will be added back if approved. Thanks!

@github-actions
Copy link

Hi @Shivkant-Chauhan, thanks for proposing this as a good first issue. I am removing the label for now and looping in @DubeySandeep to approve the label. It will be added back if approved. Thanks!

@caramelmelmel
Copy link

Hi @ashish-patwal and @Shivkant-Chauhan can I get 7 and 8 of exploration creator assigned to me? thank you! since it's my first time writing such acceptance testing, i might need some time or guidance on this aspect.

  1. As a pre-requisite, does my browser need to redirect to the /creator-dashboard route?
  2. If there are bugs encountered in the code that is to be tested, do I flag or fix the developed code bugs?
  3. Also, having done some user testing, can I suggest some UX changes? One example is the placing of the icons that may be unintuitive
    Thank you!

@Shivkant-Chauhan
Copy link
Contributor Author

Hi @ashish-patwal and @Shivkant-Chauhan can I get 7 and 8 of exploration creator assigned to me? thank you! since it's my first time writing such acceptance testing, i might need some time or guidance on this aspect.

  1. As a pre-requisite, does my browser need to redirect to the /creator-dashboard route?
  2. If there are bugs encountered in the code that is to be tested, do I flag or fix the developed code bugs?
  3. Also, having done some user testing, can I suggest some UX changes? One example is the placing of the icons that may be unintuitive
    Thank you!

Hey @caramelmelmel, assigned you to the 7,8 user stories of exploration creator and thanks for showing your interest in the Acceptance tests. I and @ashish-patwal will be there for you for clearing your blockers and helping you out when stuck. But get a fair idea by reading the wiki pages for Acceptance tests and go through the reference PR #16394 (links are shared within the issue desc.).

1 --> yes, you need to have the local server setup on your system and you must be accessible to the /creator-dashboard page. also, you need to have a proper idea of all the components present on the page and what must be the expected behavior of the components (if there is a bug anywhere).
2 --> if you are able to fix the bug within the PR itself, that would be very appreciable. otherwise, you need to open an issue for the bug you encountered with proper desc.
3 --> it depends if your idea seems good to the product reviewers, then we can implement your suggested changes.

@marcella-stefan
Copy link

Hello @ashish-patwal and @Shivkant-Chauhan, it's my first time contributing to an open source software and I would like to get assigned to (5,6) Exploration Creator or/and Anonymous Learner(3,4)?

@Shivkant-Chauhan
Copy link
Contributor Author

Hello @ashish-patwal and @Shivkant-Chauhan, it's my first time contributing to an open source software and I would like to get assigned to (5,6) Exploration Creator or/and Anonymous Learner(3,4)?

hey @marcella-stefan , since you are new to the codebase, so I am assigning you only 1 package from Exploration Creator. Please ask here in case of any blocker/confusion.

@Shivkant-Chauhan
Copy link
Contributor Author

@caramelmelmel please share the updates on the package you are assigned.

@SahilB1
Copy link

SahilB1 commented Mar 22, 2023

Hi @Shivkant-Chauhan and @ashish-patwal, this is my first time contributing to an open source project as well, would I be able to get assigned to Logged-in user browsing static pages (3, 11)?

@Shivkant-Chauhan
Copy link
Contributor Author

Hi @Shivkant-Chauhan and @ashish-patwal, this is my first time contributing to an open source project as well, would I be able to get assigned to Logged-in user browsing static pages (3, 11)?

sure @SahilB1 ! assigning you to the requested package.

@SahilB1
Copy link

SahilB1 commented Mar 22, 2023

@Shivkant-Chauhan Thank you! Will the acceptance tests wiki page have the information needed to get started on understanding how to go about writing these tests?

@SahilB1
Copy link

SahilB1 commented Mar 22, 2023

@Shivkant-Chauhan @ashish-patwal I tried to run the acceptance tests as they are using the command python -m scripts.run_acceptance_tests from my root directory of oppia, but I'm getting a No module named scripts.run_acceptance_test error when I try to run the command.

Additionally, running jasmine --config="core/tests/puppeteer-acceptance-tests/jasmine.json" core/tests/puppeteer-acceptance-tests/spec/blog-editor-tests/check-blog-editor-unable-to-publish-duplicate-blog-post.spec.js as the example test in the acceptance test page yields the response

Running suite with 0 specs. No specs found Finished in 0.002 seconds Incomplete: No specs found

Looking into the actual scripts directory in my cloned repo, it looks like run_acceptance_test.py does not exist in this directory. Could it have moved elsewhere or have been renamed?

@Shivkant-Chauhan
Copy link
Contributor Author

@Shivkant-Chauhan @ashish-patwal I tried to run the acceptance tests as they are using the command python -m scripts.run_acceptance_tests from my root directory of oppia, but I'm getting a No module named scripts.run_acceptance_test error when I try to run the command.

Additionally, running jasmine --config="core/tests/puppeteer-acceptance-tests/jasmine.json" core/tests/puppeteer-acceptance-tests/spec/blog-editor-tests/check-blog-editor-unable-to-publish-duplicate-blog-post.spec.js as the example test in the acceptance test page yields the response

Running suite with 0 specs. No specs found Finished in 0.002 seconds Incomplete: No specs found

Looking into the actual scripts directory in my cloned repo, it looks like run_acceptance_test.py does not exist in this directory. Could it have moved elsewhere or have been renamed?

we are still having a PR opened on that (#17364 ) that will fix both the things you asked for.
for now, run tests with: jasmine --config=core/tests/puppeteer-acceptance-tests/jasmine.json --filter="Blog Editor"
As soon as the above PR is merged, all the things will be running smoothly as stated in the wiki pages.

@SahilB1
Copy link

SahilB1 commented Mar 22, 2023

@Shivkant-Chauhan sounds good, thank you!

@caramelmelmel
Copy link

Thanks for the response! I'm also experiencing the same issue! In the meantime, could we copy the PR that fixes #17364 to run the acceptance tests?

@Shivkant-Chauhan
Copy link
Contributor Author

@caramelmelmel @SahilB1 until the PR #17364 is not merged, please run the test using: jasmine --config=core/tests/puppeteer-acceptance-tests/jasmine.json --filter="Blog Admin" command in your root /oppia directory

@U8NWXD U8NWXD added the Impact: Medium Will improve quality-of-life for at least 30% of users. label Mar 24, 2023
@caramelmelmel
Copy link

sure! thank you so much! right now, I'm asking for signed in users wise, must I mock the sign in phase?

github-merge-queue bot pushed a commit that referenced this issue Apr 16, 2024
* acceptance for voiceover admin

* checkpoint

* fixed first test

* fixed second test

* first pass review

* updated expectVoiceoverArtistsToContain to be plural

* updated expectVoiceoverArtistsToContain to be plural

* second pass review

* third pass review

* top level-test

* top level-test

* fixed invalidId test

* fixed invalidId test

* mobile tests

* updated error

* explorationEditor utility

* mobile test

* rename expectVoiceoverArtistsListDoesNotContain
github-merge-queue bot pushed a commit that referenced this issue Apr 20, 2024
…tab of the exploration creator. (#19828)

* exploration editor acceptance test

* fixed linting failures

* linting error fixed

* linting errors fixed

* linter

* fixex

* fixing

* fixes

* lint

* correction

* correction

* correction

* correction

* flakes fixed

* fixed flakes

* fixed flakes

* lint

* lint

* parameterized the functions

* lint

* lint fix

* lint

* lint fix

* lint fix

* lint

* fixes

* lints

* lint fixes

* lint fix

* lint fix

* resolved conflicts

* migrated to ts

* lint fix

* lint fix

* lint fix

* type fix

* lint fix

* refactoring

* changes

* updating

* lint

* correction

* lint

* lint

* updated

* correct

* updates

* updates

* updates

* fixig flakes

* updates

* updates

* fixes

* fixes

* updates

* updates

* updates

* updates

* updates

* updates

* updates

* updates

* updates

* updates

* updates

* updates

* updates

* updates
AFZL210 added a commit to AFZL210/oppia that referenced this issue Apr 21, 2024
github-merge-queue bot pushed a commit that referenced this issue Apr 22, 2024
…ection(CUJ 9). (#19780)

* firstcommitBasicSetting/advancedsettingCompleted

* Some flaky modification needed else done with the pr

* Lint Checks Failed

* lint-checks-failed

* Lint-checks-breaking

* Lint-updates

* mention-changes-seperateTesting-

* Lint-Check-Passed

* Lint-Checked-Passed

* Parameterised-required-functions

* allign-functions-correctly

* lintpass

* Merged changes from both branches

* resolve merge conflict

* removing-added-ids

* add suitable class instead of id as per review

* correct the class name

* GiveParametersToAllNeededFunctions

* PullRequestFinalised

* LintPassed

* PassFailingFlake

* Resolve-Merge-conflict

* delete-class-update-showMessageOfSuccessfullExplrationCreation-function

* remove space from top

* change expectgoaltobeset -> expectGoalToEqual

* change expectCategoryToBeSelected-> expectSelectedCategoryToBe

* update expectLanguageToBeSelected->expectSelectedLanguageToBe

* change successfullyUpdatedSettings->updateSettingsSuccessfully

* add-check-of-summary-visible-in-main-function-only

* updateAutomaticTextToSpeech -> disableAutomaticTextToSpeech

* makeExplorationPublic -> publishExploration

* add 3 inputs to voiceArtists, disableATT -> enableATT

* chooseToReceiveSuggestedEmailsAsNotification() -> optInToEmailNotifications()

* Notification --> Notifications

* it(should create an exploration and modify it via the Settings tab)

* go to a URL->openCreatorDashboardPage()

* goToEditorSection->switchToEditorTab

* change addSomeChanges -> updateTitle and more readable form

* some lint pass

* remove-unnecessary-logs

* updateTitle --> addTitle

* add list of tags

* expextExplorationToBeDeletedSuccessfully --> expectExplorationToBeDeletedSuccessfullyFromCreatorDashboard

* should draft, discard and publish the changes

* addInteraction -> addEndInteraction

* pass

* lintpass

* explorationVisitor try to visits deleted exploration

* selectLang -> selectEngLang, similiarly selectCateogry

* add comments for better understanding of PM

* add comments for better understanding of PM

* remove unwanted function extraClick

* passing-ci-tests

* lint pass

* lint-pass

* lint-pass

* lint-pass

* lint-pass

* lint pass

* correct comma in suiteName

* correct view port hieght

* correct the CI tests

* lint pass

* lint pass

* lint pass

* correct the names

* Goal -> goal

* cateogry-> category

* again

* use variable instead of direct selector

* remove some grammatical errors and use loop for repeated tasks

* use username instead of user1 and user2 as parameter

* lint pass

* remove most of the waitForTimeout(2 left)

* lint pass

* test flakes

* flakes

* flakes

* trying to reomve flakes, No flakes in local(only on github cli)

* trying to reomve flakes, No flakes in local(only on github cli)

* trying to reomve flakes, No flakes in local(only on github cli)

* remove flakes

* remove mat selector to remove flakes

* checking whether previous commit has similiar issue or not

* back to previous commit with some changes

* adding explicit timeout and checking for results

* trying after removing one of 2 Timeout checking if it works on cli or not

* continue removing flakes from github cli, this time remove some clickOn , using type directly

* remove category flake

* Add some parameters, remove mat selectors, use selectors present in codebase, give comments for explicit timeout

* lint pass

* github ci failing

* ci paas continue

* visible:true not working, need to use waitForTimeout

* ci tests : Remove visible: true , checking if publishExploration works or not

* added debugging statement to debug more deeply.

* debugigng

* debugigng

* debugigng

* debugigng expectedGoal

* using ng-reflect-model instead of explorationObjective

* trying mat-form-field.e2e-test-exploration-category .mat-select in category dropdawn as a selector, input as HTMLInputElement in expexpect goal

* adding more debuuging logs and lines in expectGoal to debug why its not working

* adding more debuuging logs and lines in Goal to debug why its not working

* checking without expect

* checking without expect

* checking without expect

* previous blockage get removed

* previous blockage get removed

* again started working fine in local after removing merge conflicts

* lint check

* lint check

* with 3 explicit timeout ci was passing, i removed all of them, lets see, (although its passing in local)

* add some classes and do some adjustments so that in mobile it also works

* undo unnecessary change of puppeteer

* undo unnecessary change of puppeteer

* add if condition for mobile, remaining

* remove debuuging logs as now working fine on github cli

* debug and make the remaining tests run

* make the selectors more selective and run the tests locally 10+ times without any flake

* chnages done (stephen)

* remove some logs message

* notification -> notifications

* notification -> notifications

* change

* changes

* resolve comments and merge conflict

* some console error mentioned

* changes done

* everything is working fine expect lost-changes-modal.component.html

* removed save-draft-spec file

* CHANGES IN EXPLORATIONID

* change

* change

* change

* lint check

* changes
github-merge-queue bot pushed a commit that referenced this issue Apr 26, 2024
…tests (#19914)

* Create acceptance test files and implement functionality to add skills

* Add functionality to create questions

* Add functionality to create explorations

* Add thumbnail image and topic creation functionality

* Add functionality to create subtopics, stories, chapters, and publish stories

* Write the acceptance tests to create topics, stories, chapters, and publish stories

* Migrate curriculum admin tests to TypeScript

* Add comments and fix tests

* Merge remote-tracking branch 'upstream/develop' into curriculum-admin-topic-management-acceptance-test

* Fix linting issues

* Fix utility functions

* Fix tests by adding timeouts for improved stability

* Clean code

* Fix typescript issues and set the main page to the active tab

* Change comments for clarity

* Add expectation tests

* Fix linting issues

* Improve extracting exploration ID and handle exceptions

* Correct wordings and input texts

* Remove redundant wait and make question creation functionality independent of user flow

* Add comments explaining timeouts and generalize functionality for timeout event

* Fix opening skill editor before question creation

* Refactor story creation to combine functions following user flow

* Modify functionalities to use objects for user input information

* Fix handling necessary question creation

* Complete topic creation functionality including publishing topic

* Appropriately publish topics, update expectance test and replace timeouts

* Add comments for clarity

* Move helper function to spec file

* Clean code and add comments

* Fix linting issues

* Minimize flaky behaviour appropriately

* Clean code

* Modify tests to emulate mobile user behaviour

* Adjust utility to publish topics for mobile functionality

* Remove test timeouts

* Improve saving topic draft flow

* Fix new tab flake and finalize mobile utility functions

* Move exploration ID extraction function to base user utility service

* Remove objects and pass data as explicit arguments

* Fix linting issues

* Address comments and improve clarity

* Improve user utility functionality

* Reduce flakiness and improve naming

* Fix linter issues

* Fix flake and improve naming

* Fix typos and improve comments

* Fix merge issues and update suite

* Attempt to fix CI error

* Create explorations from exploration editor utils to avoid code duplication

* Remove unused variables
shivanandan17 pushed a commit to shivanandan17/oppia that referenced this issue Apr 29, 2024
…ance tests (oppia#19914)

* Create acceptance test files and implement functionality to add skills

* Add functionality to create questions

* Add functionality to create explorations

* Add thumbnail image and topic creation functionality

* Add functionality to create subtopics, stories, chapters, and publish stories

* Write the acceptance tests to create topics, stories, chapters, and publish stories

* Migrate curriculum admin tests to TypeScript

* Add comments and fix tests

* Merge remote-tracking branch 'upstream/develop' into curriculum-admin-topic-management-acceptance-test

* Fix linting issues

* Fix utility functions

* Fix tests by adding timeouts for improved stability

* Clean code

* Fix typescript issues and set the main page to the active tab

* Change comments for clarity

* Add expectation tests

* Fix linting issues

* Improve extracting exploration ID and handle exceptions

* Correct wordings and input texts

* Remove redundant wait and make question creation functionality independent of user flow

* Add comments explaining timeouts and generalize functionality for timeout event

* Fix opening skill editor before question creation

* Refactor story creation to combine functions following user flow

* Modify functionalities to use objects for user input information

* Fix handling necessary question creation

* Complete topic creation functionality including publishing topic

* Appropriately publish topics, update expectance test and replace timeouts

* Add comments for clarity

* Move helper function to spec file

* Clean code and add comments

* Fix linting issues

* Minimize flaky behaviour appropriately

* Clean code

* Modify tests to emulate mobile user behaviour

* Adjust utility to publish topics for mobile functionality

* Remove test timeouts

* Improve saving topic draft flow

* Fix new tab flake and finalize mobile utility functions

* Move exploration ID extraction function to base user utility service

* Remove objects and pass data as explicit arguments

* Fix linting issues

* Address comments and improve clarity

* Improve user utility functionality

* Reduce flakiness and improve naming

* Fix linter issues

* Fix flake and improve naming

* Fix typos and improve comments

* Fix merge issues and update suite

* Attempt to fix CI error

* Create explorations from exploration editor utils to avoid code duplication

* Remove unused variables
@pritam2317
Copy link
Collaborator

Hi @seanlip can you assign me to the curiculum admin (2) ?

@jnvtnguyen jnvtnguyen removed their assignment May 7, 2024
@Nik-09
Copy link
Member

Nik-09 commented May 7, 2024

Hi @seanlip can you assign me to the curiculum admin (2) ?

Done

github-merge-queue bot pushed a commit that referenced this issue May 11, 2024
* Fix part of #17712: acceptance test for logged-in user - test subscribe

* add test

* supress console errors

* add mobile test

* fix linter

* add space

* add comments

* update test

* fix linter

* fix test

* use functions of exploration editor

* add full stop

* refactor code

* fix linter
@Akhilesh-max Akhilesh-max changed the title Acceptance Testing - covering all user journeys in form of user stories Acceptance Testing - covering all the Creator's and Contributor's CUJs. May 29, 2024
@Akhilesh-max
Copy link
Contributor

The list of journeys mentioned above is not exhaustive. I will continue adding the creator’s and contributor’s CUJs that need to be documented. @rahat2134, would you like to help me with this? Perhaps you would be having a list of creator’s and contributor’s CUJs?

github-merge-queue bot pushed a commit that referenced this issue Jun 12, 2024
…UJ 2.1). (#20431)

blog-editor-create-delete-drafted-post
github-merge-queue bot pushed a commit that referenced this issue Jun 13, 2024
…ection(CUJ 10). (#20203)

* saveDraft spec

* change

* change

* change

* changes

* changes

* changes

* changes

* changes-> waitForPageToFullyLoad,...

* correct function name in new PR

* removed timeout

* div -> button

* change

* remove-extra-regex

* changes

* changes

* changes

* autosave indicator to a variable

* changes

* corrected the doc string
github-merge-queue bot pushed a commit that referenced this issue Jun 23, 2024
)

* Footer navigation logged-in user tests progress

* Click all buttons on get started page done

* logged in users get started page test refactoring

* click all about oppia footer buttons test working

* Lint fixes

* Lint fixes

* Lint fixes

* null-safety

* Add /usr/bin/google-chrome-stable as possible CHROME_BIN path

* click all about oppia footer buttons changes

* Fix some flakiness for logged in user acceptance tests

* Remove extra space

* Matcher changes for logged-in-users-utils

* Swap ` with \' on non-format string

* Swaping a .toContain to a .toBe

* Rename of some logged in user tests and restructuring of the click all likns on get started page spec

* Click all links on creator guidelines page acceptance test

* More logged-in user test progress

* Logged in user tests for teach and terms pages

* logged-in-user-utils constant changes

* Logged-in users Social icons and privacy page tests

* Fix linter errors

* Last logged-in users test

* remove duplicate member from logged-in-user-utils

* logged in user test documentation updates

* fix broken acceptance test, logged-in-user-tests/click-all-links-on-get-started-page

* Attempt to lower flakiness of following links to social media sites

* Remove extra dash in acceptance suite name

* Fix typos in logged-in-user-tests

* Footer icon click functions renames

* Add missing function documentation

* Remove some empty lines

* Add new test suite

* move tests into click-all-links-in-teach-learn-footer spec

* Rename some logged-in-user-util functions

* fix logged-in-user-tests/click-all-buttons-on-teach-page.spec.ts

* Add test for Google Play button

* Fix typo

* Renaming symbols and more test reshuffling

* move some constants to test-contants.ts

* move some constants to test-contants.ts

* fix incorrect named symbol

* Replace tests that where accidentaly removed when merging

* Add test to click Privacy Policy link on terms page

* More logged in test changes

* Change domain for twitter

* Fix symbols for logged-out-user tests

* minor documentation change ('logged-in' -> 'logged-out')

* Remove teach page acceptance test on this branch since it exists in develop already

* Merge oppia footer tests into one file

* fix linter issues

* Fix footer test flake

* uncomment out test

* fix acceptance test flakes

* rename click-all-links-in-terms-page test to click-all-links-on-terms-page

* remove extra function declaration

---------

Co-authored-by: Hardik Goyal <135348086+HardikGoyal2003@users.noreply.github.com>
github-merge-queue bot pushed a commit that referenced this issue Jun 23, 2024
…UJ 2.2). (#20512)

* blog editor cuj 2.2

* changes suggested by christie, use constant..

* changes

* changes
@Akhilesh-max Akhilesh-max removed their assignment Jul 6, 2024
github-merge-queue bot pushed a commit that referenced this issue Jul 17, 2024
…ction(CUJ 12). (#20669)

* Exploration-editor-CUJ-12

* Add proper specs

* Add proper specs

* changes
imchristie pushed a commit to imchristie/oppia that referenced this issue Jul 18, 2024
…or Section(CUJ 12). (oppia#20669)

* Exploration-editor-CUJ-12

* Add proper specs

* Add proper specs

* changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Label to indicate an issue is a regression Impact: Medium Will improve quality-of-life for at least 30% of users. Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet.
Projects
Status: In Progress
Status: In progress