Fix part of #17712 Add more acceptance tests for logged in users

[agallop]

Overview

1. This PR fixes or fixes part of Acceptance Testing - covering all the Creator's and Contributor's CUJs. #17712
2. This PR does the following: Adds several acceptance tests for logged-in users:\
   • click-all-links-on-creator-guidelines-page
   • click-all-links-on-privacy-policy-page
   • click-all-links-on-terms-page
   • click-more-links-in-oppia-footer
3. (For bug-fixing PRs only) The original bug occurred because: N/A

Essential Checklist

Please follow the instructions for making a code change.

• I have linked the issue that this PR fixes in the "Development" section of the sidebar.
• I have checked the "Files Changed" tab and confirmed that the changes are what I want to make.
• I have written tests for my code.
• The PR title starts with "Fix #bugnum: " or "Fix part of #bugnum: ...", followed by a short, clear summary of the changes.
• I have assigned the correct reviewers to this PR (or will leave a comment with the phrase "@{{reviewer_username}} PTAL" if I can't assign them directly).

Proof that changes are correct

Here are the github action runs for the acceptance tests for this PR which shows that:

• The github actions are configured correctly.
• The tests run to completion and do not fail for desktop and mobile.
• No existing tests have started to fail.

Action summary

• click-all-buttons-on-teach-page
• click-all-links-on-creator-guidelines-page
• click-all-links-on-privacy-policy-page
• click-all-social-icons-in-oppia-footer
• click-all-links-on-terms-page
• click-more-links-in-the-oppia-footer

Proof of changes on desktop with slow/throttled network

N/A

Proof of changes on mobile phone

Action summary

• click-all-buttons-on-teach-page
• click-all-links-on-creator-guidelines-page
• click-all-links-on-privacy-policy-page
• click-all-social-icons-in-oppia-footer
• click-all-links-on-terms-page
• click-more-links-in-the-oppia-footer

Proof of changes in Arabic language

N/A

PR Pointers

• Never force push! If you do, your PR will be closed.
• To reply to reviewers, follow these instructions: https://github.com/oppia/oppia/wiki/Make-a-pull-request#step-5-address-review-comments-until-all-reviewers-approve
• Some e2e tests are flaky, and can fail for reasons unrelated to your PR. We are working on fixing this, but in the meantime, if you need to restart the tests, please check the "If your build fails" wiki page.
• See the Code Owner's wiki page for what code owners will expect.

[imchristie]

@agallop, seem like there's a failure in CI for logged-out-user/check-all-user-flow-of-partner because you removed the function navigateToAboutFoundationPageViaFooter.

[oppiabot]

Hi @agallop. Due to recent changes in the "develop" branch, this PR now has a merge conflict. Please follow this link if you need help resolving the conflict, so that the PR can be merged. Thanks!

[oppiabot]

Hi @agallop. Due to recent changes in the "develop" branch, this PR now has a merge conflict. Please follow this link if you need help resolving the conflict, so that the PR can be merged. Thanks!

[HardikGoyal2003]

@seanlip can we merge this PR?

[seanlip]

@HardikGoyal2003 I think you mentioned the wrong username there...

In any case: generally, a PR can be merged when all reviewers approve and all CI checks pass. In this case, a CI check is failing. The right thing to do in that case is to look at the logs, see if it's a flake, report it if so (e.g. add a note to an issue), and restart the test. If it's not a flake then the author needs to fix it.

You can apply this general process to all PRs.

[HardikGoyal2003]

Merging this PR as all CI checks have passed and it has been approved by all reviewers.