Fix key release blockers of the contributor admin dashboard

[chris7716]

This issue aims to fix the key issues that block the launch of the contributor admin dashboard.

Available Tasks

Assigned Tasks

Fixed Tasks

• Question Coordinator: The “Displaying 1-17 of many” seems odd since there are only 17 results and the page size is 20. Shouldn’t it be “Displaying 1-17 of 17”? I.e. when there are no more pages, “many” should be replaced by the total number of entries. (See Fix part of #19570: pagination ui in contribution admin dashboard table #19592 for partial previous work.) @stevenjgodfrey
  

• Edit “role” the cancel button does not work on my end. After click “cancel” the pop-up window still there. A bit of unclear why need to edit role. @DmirtyUsov
  

• Some errors observed on console. @stevenjgodfrey
  

• No data loads for me when I visit the page. I am a curriculum, translation, voiceover and question admin at this point, but not a translation or question coordinator. The page should show a 401 error if I do not have the required permissions. Despite not having actual access I am able to click on the “Add reviewer” button; this is wrong. @Aakash-Jakhmola

• Why is this square showing? as a first time user i think the is something which i can not see @Aakash-Jakhmola
  

• There is no indication that person have to select a language to check the status , at first i thought why this number is 0 then i choose language and data shows up @Aakash-Jakhmola
  

• Question Coordinator: The “17” in “Question Reviewers” should be higher so that there is space between it and the bottom edge of the white box. @stevenjgodfrey
  

• Question Coordinator: The second-last column in this table does not make sense (it says “Last Reviewed” but this is a table of Question Submitters. @stevenjgodfrey
  

• Question Coordinator: There should be more space between the text and the bottom of the gray box. (In the screenshot, the list of topics actually continues for a third line below the box.) @stevenjgodfrey
  

• Question Coordinator: I opened the roles for a user and removed the question reviewer role. I saved the changes. There is no indicator that the changes were successfully saved (I would expect a green toast at the bottom right). When I reopened the modal, both the question submitter and reviewer roles were unchecked, even though I had only removed the reviewer role. @stevenjgodfrey
  Before
  

After

• I have not selected any language, so what does this number depict? Translation reviewer and Question reviewer for which language and which topics or overall/total number. @stevenjgodfrey
  

• For language drop down menu its better that we start every language in english first , as this will be easy to search. Suggestion: change headers to “Recent Performance” and “Overall Accuracy” @masterboy376
  

• For language drop down menu its better that we start every language in english first , as this will be easy to search @Aakash-Jakhmola
  

• Change "Question Reviewers" -> "Practice Question Reviewers" @stevenjgodfrey
  

• Placeholder still showing after a topic is selected. Took a while to realize that it could mean that more than 1 topic can be selected. However it is impossible on my end to select more than 1 topic. (Description - I try typing the 2nd topic, the options pop up, I select the topic it searches and shows an incomplete word. See 2nd screenshot. @stevenjgodfrey
  
  

• Change the URL of the dashboard page from /contributor-dashboard-admin to /contributor-admin-dashboard. @sumitks866

How to test all the changes:

1. Run the development server
2. Give yourself "Release Coordinator", "Translation Coordinator", "Question Coordinator" role from /admin page(Roles tab)
3. Then goto the /release-coordinator page
4. Turn on the cd_admin_dashboard_new_ui feature. https://github.com/oppia/oppia/wiki/Launching-new-features
5. Then goto /contributor-dashboard-admin
6. To populate data on Contributor Dashboard https://docs.google.com/document/d/1JYX4nvTcblaVVYAlTi7rApE0lWSBx0v_ZCCr_8WW4Wc/edit#heading=h.1nfdy29ioghr

Helpful Tips

Seeking Help: If you encounter persistent errors after applying your changes and can't resolve them despite multiple attempts, you can seek assistance from @chris7716 and others. To do this effectively:

• Prepare a Draft PR: Initiate a draft pull request on GitHub incorporating all your changes.

• Document Your Attempts: Create a debugging doc to fully describe the issues you are running into and the solutions you've tried, so that others can help you more easily.

• Reach Out for Help: Contact @chris7716 via email (hkraclh@gmail.com). Include in your communication:

  • The specific error you're encountering.
  • The link to your draft PR.
  • The debugging doc, which includes the list of solutions you've already attempted.
  • Email title with "Need help with #19435"

  In addition, please leave a comment on this issue thread with the above details as well.

[github-actions]

Hi @chris7716, thanks for proposing this as a good first issue. I am removing the label for now and looping in @DubeySandeep to approve the label. It will be added back if approved. Thanks!

[Aakash-Jakhmola]

Hi @chris7716 ,
Not able to reproduce the 2nd issue i.e. No data loads for me when I visit the page.

I have the following roles,

• Full User
• Question Admin
• Release Coordinator
• Curriculum Admin
• Translation Admin
• Voiceover Admin

Then I get 401.

[seanlip]

@Aakash-Jakhmola It sounds like that specific issue might be fixed? If so, feel free to mark it off as done (probably a bonus if you can find the PR which fixed it, but not essential).

Thanks!

[Aakash-Jakhmola]

@chris7716

There is no indication that person have to select a language to check the status , at first i thought why this number is 0 then i choose language and data shows up.

Why is this square showing? as a first time user i think the is something which i can not see

These issues are not reproducible.

[stevenjgodfrey]

I think this issue "Question submitter tab: tab name difference. As per Cuj excel sheet Last Submitted: column name should be there but its showing Last reviewed" is aduplicate of "uestion Coordinator: The second-last column in this table does not make sense (it says “Last Reviewed” but this is a table of Question Submitters" which is being fixed by me.

[stevenjgodfrey]

I'm happy to pick up this issue "According to CUJ for new contributor Rank should be there when we click on the name of question submitter but No rank is showing"

[chris7716]

I'm happy to pick up this issue "According to CUJ for new contributor Rank should be there when we click on the name of question submitter but No rank is showing"

Done

[chris7716]

@chris7716

There is no indication that person have to select a language to check the status , at first i thought why this number is 0 then i choose language and data shows up.

Why is this square showing? as a first time user i think the is something which i can not see

These issues are not reproducible.

Marked as Done

[masterboy376]

Hello @chris7716 and @seanlip
Apologies for delayed response.
As per the suggestion I changed headers to "Recent Performance" and "Overall Performance". (Task assigned to me)

Made Following changes:

Please Take a Look
Also is it fine to complete multiple task in a single PR.

[sumitks866]

Hello @seanlip @chris7716
I would like to fix this part

Change the URL of the dashboard page from /contributor-dashboard-admin to /contributor-admin-dashboard.

For this, I will change CONTRIBUTOR_DASHBOARD_ADMIN_URL = '/contributor-dashboard-admin' at line 932 in core/feconf.py to CONTRIBUTOR_DASHBOARD_ADMIN_URL = '/contributor-admin-dashboard'.

Thanks.

[seanlip]

@sumitks866 OK, thanks, go for it!

[stevenjgodfrey]

Hi @chris7716, I'm happy to pick up this unassigned item "Placeholder still showing after a topic is selected. Took a while to realize that it could mean that more than 1 topic can be selected. However it is impossible on my end to select more than 1 topic. (Description - I try typing the 2nd topic, the options pop up, I select the topic it searches and shows an incomplete word. See 2nd screenshot."

[stevenjgodfrey]

I think this issue "Question submitter tab: tab name difference. As per Cuj excel sheet Last Submitted: column name should be there but its showing Last reviewed" is aduplicate of "uestion Coordinator: The second-last column in this table does not make sense (it says “Last Reviewed” but this is a table of Question Submitters" which is being fixed by me.

I think this is fixed now, I can add multiple topics

[stevenjgodfrey]

@chris7716 - I will pick up the unassigned task " In “Question Submitters” reporting, the table header - “user” will bring confusion. Same in “Question reviewer”. The user here is “question submitter or reviewer” ?"

I will change to user to say Question submitter or reviewer.

[StephenYu2018]

@stevenjgodfrey Sorry, I just removed the unassigned task from this issue, since the CD team leads and I concluded earlier today that it doesn't block the release of the CD admin dashboard. Could you please pick a different task amongst the list?

[StephenYu2018]

I think this issue "Question submitter tab: tab name difference. As per Cuj excel sheet Last Submitted: column name should be there but its showing Last reviewed" is aduplicate of "uestion Coordinator: The second-last column in this table does not make sense (it says “Last Reviewed” but this is a table of Question Submitters" which is being fixed by me.

I think this is fixed now, I can add multiple topics

Have you opened a PR for this yet?

[stevenjgodfrey]

@stevenjgodfrey Sorry, I just removed the unassigned task from this issue, since the CD team leads and I concluded earlier today that it doesn't block the release of the CD admin dashboard. Could you please pick a different task amongst the list?

Ok, I'll take a look at something else

[stevenjgodfrey]

I think this issue "Question submitter tab: tab name difference. As per Cuj excel sheet Last Submitted: column name should be there but its showing Last reviewed" is aduplicate of "uestion Coordinator: The second-last column in this table does not make sense (it says “Last Reviewed” but this is a table of Question Submitters" which is being fixed by me.

I think this is fixed now, I can add multiple topics

Have you opened a PR for this yet?

I meant this currently works on develop, so must have been fixed previously.

[chris7716]

@seanlip could you please elaborate from the product perspective on:

On selecting a language, the number of translation reviewers changes but the number of question reviewers doesn’t change (either based on language or based on topic). A user may find it difficult to comprehend what that number depicts. Unclarity due to word choice - There is a language indication under Translation reviewers but not under question reviewers. First, does the “question” here refer to practice questions? If in future, the practice questions are translated into other languages and reviewed, where does it eventually fall under?

What should we do for this?

And also for this one:(Should we keep it in the list??)

Question submitter Tab Performance tab still not clear

[seanlip]

@chris7716

On selecting a language, the number of translation reviewers changes but the number of question reviewers doesn’t change (either based on language or based on topic). A user may find it difficult to comprehend what that number depicts. Unclarity due to word choice - There is a language indication under Translation reviewers but not under question reviewers. First, does the “question” here refer to practice questions? If in future, the practice questions are translated into other languages and reviewed, where does it eventually fall under?

Let's leave this for now -- the only fix I would suggest is to change "Question Reviewers" at the top to "Practice Question Reviewers".

Question submitter Tab Performance tab still not clear

OK to drop this from the list.

[masterboy376]

This PR is now ready for review. Pardon for delay.